Skip to content

util: add non-throwing util.isPartialDeepStrictEqual - #66118

Open
tlhunter wants to merge 1 commit into
nodejs:mainfrom
tlhunter:tlhunter/util-isPartialDeepStrictEqual
Open

tlhunter wants to merge 1 commit into
nodejs:mainfrom
tlhunter:tlhunter/util-isPartialDeepStrictEqual

Conversation

@tlhunter

@tlhunter tlhunter commented Sep 18, 2026

Copy link
Copy Markdown
Contributor
  • adds a non-throwing variant of assert.partialDeepStrictEqual()
  • follows the same pattern as util.isDeepStrictEqual()

Signed-off-by: Thomas Hunter II <tlhunter@datadog.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (dd5dfb5) to head (3f0d440).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66118      +/-   ##
==========================================
+ Coverage   90.27%   90.28%   +0.01%     
==========================================
  Files         790      790              
  Lines      271651   271658       +7     
  Branches    51842    51841       -1     
==========================================
+ Hits       245228   245275      +47     
+ Misses      16928    16878      -50     
- Partials     9495     9505      +10     
Files with missing lines Coverage Δ
lib/util.js 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tlhunter

Copy link
Copy Markdown
Contributor Author

FYI @BridgeAR

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR! I think it is nice to also expose this API

The only thing that should be adjusted is the module scope. Mind updating the commit message accordingly by rebasing (it has to be the first commit)? :)

@BridgeAR BridgeAR changed the title lib: add util.isPartialDeepStrictEqual util: add non-throwing util.isPartialDeepStrictEqual Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants