vfs: make the reserved root readable through fs - #66140
pipobscure wants to merge 1 commit into
Conversation
nodejs-github-bot
added
lib / src
|
The docs for
Presumably that should be updated? |
The reason I left it because the feature is experimental and we're not constructing a mount-paths, but rather the well-known root of all vfs-mounts. Though that's debatable. I'll go with whatever you say, but am happy to remove it if this rationale seems too flimsy. The question that brought up for me though is whether we want a |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66140 +/- ##
==========================================
+ Coverage 90.28% 90.29% +0.01%
==========================================
Files 790 791 +1
Lines 271982 272314 +332
Branches 51915 51999 +84
==========================================
+ Hits 245546 245882 +336
+ Misses 16947 16930 -17
- Partials 9489 9502 +13
🚀 New features to boost your workflow:
|
|
Mostly I just don't like it when docs seem to contradict themselves; I always assume I'm misreading something. (Right now one part of the docs appears to be saying "don't assume things are under devnull" and another says to enumerate devnull.) Adding |
badc074 to
4782615
Compare
|
Heads-up for reviewers: this branch now also reserves layer id 0 for the file system What changed:
Why it matters: the mount point of a One thing worth deciding: the reservation is currently only stated in code comments. |
The reserved root `${os.devNull}/vfs`, which holds the mount points of
all virtual file systems, could not be read: fs calls on it fell through
to the real file system, so nothing could list what was mounted.
While any file system is mounted, serve the root as a read-only
directory. It lists every mount point by its layer id, a recursive
listing descends into each mounted file system, and paths under it that
no mount serves report ENOENT. Creating, removing or changing entries in
it fails with EROFS. When nothing is mounted it does not exist, as
before.
A mount point cannot be removed or renamed, nor replaced by a rename:
rmdir() and rename() fail with EBUSY, and a recursive rm() empties the
file system and then fails the same way. Before, rmdir() of an empty
mount point reported success without doing anything.
Reserve layer 0 for the file system --vfs-load mounts, and number the
others from 1. That source is then at the same reserved mount point in
every thread, whatever else a thread mounts and wherever --vfs-load is
written among the other mounts, so a path into it stays valid in a
worker - including a worker created with its own execArgv, which
inherits none of the parent's options and has to be given --vfs-load
again. A worker still does not run that entry point, but it now has to
recognize which source it belongs to in order to mount it at that layer.
The callback and promise forms of readdir() with `withFileTypes` now
report each Dirent's parentPath as a host path, as readdirSync() did,
instead of the provider-relative one, and split recursive names such as
`dir/file.txt` into their directory and base name. A recursive listing
joins subdirectories with the host separator rather than `/`, which
mixed separators on Windows. realpath() of a mount point no longer
returns it with a trailing separator.
Add vfs.vfsBase(), which returns that directory, so a program can list
what is mounted without spelling out `path.join(os.devNull, 'vfs')`. The
note under vfs.mount() said the path scheme must not be relied on, which
read as a contradiction of the root being listable; it now says where a
mount point comes from, and that only the name within the root is
assigned at runtime.
Signed-off-by: Philipp Dunkel <pip@pipobscure.com>
4782615 to
a2cd24b
Compare
4 participants
The reserved root
${os.devNull}/vfs, which holds the mount points of all virtual file systems, could not be read: fs calls on it fell through to the real file system, so nothing could list what was mounted.While any file system is mounted, serve the root as a read-only directory. It lists every mount point by its layer id, a recursive listing descends into each mounted file system, and paths under it that no mount serves report ENOENT. Creating, removing or changing entries in it fails with EROFS. When nothing is mounted it does not exist, as before.
A mount point cannot be removed or renamed, nor replaced by a rename: rmdir() and rename() fail with EBUSY, and a recursive rm() empties the file system and then fails the same way. Before, rmdir() of an empty mount point reported success without doing anything.
The callback and promise forms of readdir() with
withFileTypesnow report each Dirent's parentPath as a host path, as readdirSync() did, instead of the provider-relative one, and split recursive names such asdir/file.txtinto their directory and base name. A recursive listing joins subdirectories with the host separator rather than/, which mixed separators on Windows. realpath() of a mount point no longer returns it with a trailing separator.