Skip to content

Conversation

@marco-ippolito
Copy link
Member

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings December 8, 2025 17:59
@marco-ippolito marco-ippolito requested a review from a team as a code owner December 8, 2025 17:59
@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Dec 8, 2025 6:05pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@richardlau
Copy link
Member

This only updates the blog post and not the banner.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just changing the timestamp of the blog post, not the banner?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the publication date for a security release announcement by moving it 6 hours earlier (from 23:00 to 17:00 UTC on December 8, 2025), likely to ensure the banner appears at the appropriate time before the actual security releases on December 15, 2025.

  • Updated the date field in the security release announcement metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MattIPv4
Copy link
Member

MattIPv4 commented Dec 8, 2025

(I think changing the date on the blog post would also cause RSS readers to pick it up again, which would not be ideal)

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.71%. Comparing base (a815445) to head (8405679).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8404      +/-   ##
==========================================
- Coverage   73.73%   73.71%   -0.02%     
==========================================
  Files         107      107              
  Lines        9155     9155              
  Branches      308      308              
==========================================
- Hits         6750     6749       -1     
- Misses       2403     2404       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marco-ippolito marco-ippolito force-pushed the anticipate-banner-for-release branch from c39e927 to db3e1cc Compare December 8, 2025 18:02
@marco-ippolito marco-ippolito requested a review from a team as a code owner December 8, 2025 18:02
@marco-ippolito
Copy link
Member Author

(I think changing the date on the blog post would also cause RSS readers to pick it up again, which would not be ideal)

so we should not update the blogpost?

@MattIPv4
Copy link
Member

MattIPv4 commented Dec 8, 2025

so we should not update the blogpost?

Yeh I think it'd be best to revert that

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 4.34 MB
New Total Size 4.34 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/1437458fc298411c.js 204.09 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/094bc6f9ee7fc00c.js 204.09 KB

@marco-ippolito marco-ippolito added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit ebd98f0 Dec 8, 2025
12 checks passed
@marco-ippolito marco-ippolito deleted the anticipate-banner-for-release branch December 8, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants