-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: anticipate banner for security release #8404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
This only updates the blog post and not the banner. |
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just changing the timestamp of the blog post, not the banner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adjusts the publication date for a security release announcement by moving it 6 hours earlier (from 23:00 to 17:00 UTC on December 8, 2025), likely to ensure the banner appears at the appropriate time before the actual security releases on December 15, 2025.
- Updated the date field in the security release announcement metadata
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
(I think changing the date on the blog post would also cause RSS readers to pick it up again, which would not be ideal) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8404 +/- ##
==========================================
- Coverage 73.73% 73.71% -0.02%
==========================================
Files 107 107
Lines 9155 9155
Branches 308 308
==========================================
- Hits 6750 6749 -1
- Misses 2403 2404 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
c39e927 to
db3e1cc
Compare
apps/site/pages/en/blog/vulnerability/december-2025-security-releases.md
Outdated
Show resolved
Hide resolved
so we should not update the blogpost? |
Yeh I think it'd be best to revert that |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
db3e1cc to
8405679
Compare
Description
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.