Skip to content

fix: mobile dialog close icon #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 2 commits into from
Dec 24, 2025
+18 −1
Merged

fix: mobile dialog close icon #8446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd02e12
fix: mobile close icon and focus in issue
canerakdas Dec 24, 2025
ce8de89
chore: hide in medium res
canerakdas Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ui-components/src/Common/Search/Input/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@
py-4
pr-4
pl-9
text-sm
text-base
text-neutral-900
placeholder:text-neutral-500
focus:outline-none
md:text-sm
dark:border-neutral-900
dark:text-neutral-200
dark:placeholder:text-neutral-600;
Expand Down
15 changes: 15 additions & 0 deletions packages/ui-components/src/Common/Search/Modal/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,18 @@
lg:border
dark:border-neutral-900;
}

.modalCloseButton {
@apply absolute
top-2
right-4
z-10
cursor-pointer
bg-white
px-2
text-2xl
text-neutral-950
md:hidden
dark:bg-black
dark:text-neutral-200;
}
1 change: 1 addition & 0 deletions packages/ui-components/src/Common/Search/Modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const SearchModal: FC<PropsWithChildren<SearchModalProps>> = ({
placeholder={placeholder}
ariaLabel={placeholder}
/>
<Modal.Close className={styles.modalCloseButton} />
{children}
</Modal.Content>
</Modal.Inner>
Expand Down
Loading