Skip to content

test: cover connect lookup option#5411

Open
vibhor-aggr wants to merge 1 commit into
nodejs:mainfrom
vibhor-aggr:fix/connect-lookup-docs-tests
Open

test: cover connect lookup option#5411
vibhor-aggr wants to merge 1 commit into
nodejs:mainfrom
vibhor-aggr:fix/connect-lookup-docs-tests

Conversation

@vibhor-aggr

Copy link
Copy Markdown
Contributor

Summary

  • add direct regression coverage that object-form connect.lookup is forwarded to the built connector
  • document the object-form connect.lookup pattern in Client docs

Refs: #886

Verification

  • node --expose-gc --test --test-name-pattern "passes lookup from connect options" test/client.js
  • ./node_modules/.bin/borp --timeout 180000 --expose-gc -p test/client.js
  • npm run lint -- test/client.js
  • git diff --check

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.24%. Comparing base (ac5394b) to head (1521132).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5411      +/-   ##
==========================================
- Coverage   93.25%   93.24%   -0.01%     
==========================================
  Files         110      110              
  Lines       36825    36825              
==========================================
- Hits        34340    34339       -1     
- Misses       2485     2486       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants