fix: convert parseUnparsedAttributes recursion to iteration to prevent stack overflow on malformed Set-Cookie headers - #5651
Open
mcollina wants to merge 1 commit into
Open
fix: convert parseUnparsedAttributes recursion to iteration to prevent stack overflow on malformed Set-Cookie headers#5651mcollina wants to merge 1 commit into
mcollina wants to merge 1 commit into
Conversation
…t stack overflow on malformed Set-Cookie headers
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5651 +/- ##
==========================================
+ Coverage 93.42% 93.43% +0.01%
==========================================
Files 110 110
Lines 38710 38705 -5
==========================================
Hits 36165 36165
+ Misses 2545 2540 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace recursive processing of Set-Cookie attributes with iteration. This preserves the existing parsing behavior while avoiding call-stack growth for headers with many attributes.