Skip to content

feat(i18n): add Spanish translations for profile.* entries#1764

Merged
danielroe merged 2 commits intomainfrom
userquin/feat-add-profile-spanish-translations
Mar 1, 2026
Merged

feat(i18n): add Spanish translations for profile.* entries#1764
danielroe merged 2 commits intomainfrom
userquin/feat-add-profile-spanish-translations

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 28, 2026

🔗 Linked issue

🧭 Context

📚 Description

This PR adds the following missing translations:

  • shortcuts.disable_shortcuts
  • settings.sections.keyboard_shortcuts
  • settings.keyboard_shortcuts_enabled
  • settings.keyboard_shortcuts_enabled_description
  • common.cancel
  • common.save
  • common.edit
  • common.error
  • profile.display_name
  • profile.description
  • profile.no_description
  • profile.website
  • profile.website_placeholder
  • profile.likes
  • profile.seo_title
  • profile.seo_description
  • profile.not_found
  • profile.not_found_message
  • profile.invite.message
  • profile.invite.share_button
  • profile.invite.compose_text
  • package.downloads.subtitle
  • code.scroll_to_top
  • auth.modal.profile
  • compare.file_too_large
  • compare.file_size_warning

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 28, 2026 8:48pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 28, 2026 8:48pm
npmx-lunaria Ignored Ignored Feb 28, 2026 8:48pm

Request Review

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/es-419.json Localization changed, will be marked as complete.
lunaria/files/es-ES.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

📝 Walkthrough

Walkthrough

This pull request adds new internationalisation translation keys across multiple Spanish locale files. The changes include keyboard shortcut control translations, profile-related UI strings, file comparison warning messages, and auth modal labels. The additions span four locale JSON files (es-419.json and es.json in i18n/locales, and es-419.json and es-ES.json in lunaria/files), with no modifications to existing keys.

Possibly related PRs

Suggested reviewers

  • mrcego
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly lists all 26 translation keys being added across Spanish locale files, directly matching the changeset scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch userquin/feat-add-profile-spanish-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
i18n/locales/es-419.json (1)

35-38: Trim merge-locale duplication for profile.invite.compose_text.

Line 37 appears identical to the base Spanish value, so keeping it in es-419 adds maintenance overhead without changing runtime output.

♻️ Proposed cleanup
   "invite": {
     "message": "Parece que aún no usa npmx. ¿Quieres contarle?",
-    "compose_text": "¡Hola {'@'}{handle}! ¿Has probado ya npmx.dev? Es un navegador para el registro de npm rápido, moderno y de código abierto.\nhttps://npmx.dev"
   }

Based on learnings: country variant files like es-419.json should only contain entries that differ from the base es.json file.


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04bd490 and 114a0f8.

📒 Files selected for processing (4)
  • i18n/locales/es-419.json
  • i18n/locales/es.json
  • lunaria/files/es-419.json
  • lunaria/files/es-ES.json

@danielroe danielroe added this pull request to the merge queue Mar 1, 2026
Merged via the queue into main with commit fa6078b Mar 1, 2026
21 checks passed
@danielroe danielroe deleted the userquin/feat-add-profile-spanish-translations branch March 1, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants