fix: disable some keyboard shortcuts when it's disabled in settings#1780
Draft
alex-key wants to merge 2 commits intonpmx-dev:mainfrom
Draft
fix: disable some keyboard shortcuts when it's disabled in settings#1780alex-key wants to merge 2 commits intonpmx-dev:mainfrom
alex-key wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Partially resolves #1779
🧭 Context
In #1537 we've added a mechanism which allows user to disable all custom keyboard shortcuts in Settings. So it does not conflict with browser, os or other tools user might use to browse
📚 Description
Some of widgets in the app still use custom keyboard shortcuts. This PR adds logic to disable custom behavior for the following areas: