fix: add missing changelog entry in keyboard shortcuts menu by BittuBarnwal7479 · Pull Request #2873 · npmx-dev/npmx.dev

BittuBarnwal7479 · 2026-06-07T18:55:17Z

🔗 Linked issue

🧭 Context

The - shortcut for opening the changelog tab on package is shown in the UI but missing from the Keyboard Shortcuts search section.

📚 Description

The package page shows a - keyboard shortcut for opening the changelog, but this shortcut is not listed on the Keyboard shortcuts search section.

…languages

vercel · 2026-06-07T18:55:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Jun 8, 2026 7:53pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Jun 8, 2026 7:53pm
npmx-lunaria	Ignored		Jun 8, 2026 7:53pm

coderabbitai · 2026-06-07T18:55:29Z

📝 Walkthrough

Summary by CodeRabbit

New Features
- Added a new keyboard shortcut (the “-” key) to open the changelog; it appears in the keyboard shortcuts reference modal.
Translations
- The changelog shortcut label has been added across supported locales for consistent internationalised UI.

Walkthrough

Adds a - keyboard shortcut to AppFooter’s shortcuts modal and registers a new i18n key shortcuts.section.changelog in the schema and across locale files.

Changes

Changelog keyboard shortcut

Layer / File(s)	Summary
i18n schema definition `i18n/schema.json`	The schema is extended with a new `shortcuts.section.changelog` string field to validate the translation key.
AppFooter UI component `app/components/AppFooter.vue`	A new keyboard shortcut entry for the `-` key is added to the shortcuts modal, displaying the label from the i18n `shortcuts.changelog` key.
Locale translations `i18n/locales/*`	Translation strings for `shortcuts.section.changelog` (or `shortcuts.changelog` in some locales) are added across multiple locale files to supply the changelog shortcut label in each language.

Possibly related PRs

npmx-dev/npmx.dev#2757: Related i18n updates for changelog/keyboard-shortcut strings (Spanish overlap).
npmx-dev/npmx.dev#2614: Prior changes touching AppFooter.vue keyboard-shortcuts modal UI.
npmx-dev/npmx.dev#2813: Overlaps on Turkish i18n updates for changelog/shortcuts labels.

Suggested reviewers

ghostdevv
serhalp
romansp

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a missing changelog entry to the keyboard shortcuts menu, which is the core objective of this PR.
Description check	✅ Passed	The description is directly related to the changeset, clearly explaining the issue (missing changelog shortcut from Keyboard Shortcuts search) and the solution being implemented.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-07T18:56:18Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
i18n/locales/ar.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/en.json	Source changed, localizations will be marked as outdated.
i18n/locales/hi-IN.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/nl.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

codecov · 2026-06-07T18:56:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

ghostdevv

I assume you used AI to do the translations? Usually we prefer it if you only translate the languages you're familiar with as it's easier for people to add missing translations and fix broken ones (plus gives others a good way to contribute). Otherwise LGTM

BittuBarnwal7479 · 2026-06-07T22:47:27Z

I assume you used AI to do the translations? Usually we prefer it if you only translate the languages you're familiar with as it's easier for people to add missing translations and fix broken ones (plus gives others a good way to contribute). Otherwise LGTM

Yes, I used AI to help with the translations. The change was very small, just replacing a few English text.

I agree that native speakers are best suited for translation work, and I appreciate you pointing it out. I'll keep that in mind for future translation contributions.
Thanks!

WilcoSp

Looking good, but like what ghostdev said about the translations, at least in Dutch I localise it differently

WilcoSp · 2026-06-08T19:09:02Z

    "settings": "Open instellingen",
    "compare": "Open vergelijken",
    "compare_from_package": "Vergelijking openen (vooraf ingevuld met het huidige pakket)",
+    "changelog": "Open changelog",


For Dutch this should be "Open wijzigingenoverzicht"

Also for languages you don't know I would suggest leaving them empty instead of "{open} changelog" as it can be that some languages will localise it differently compared to translating directly.

Thanks!
I agree, I'll keep that in mind for future translation contributions.

…utch locale

WilcoSp

at least for Dutch looking good now, further reviewing I'll leave up to ghostdevv.

I'll also share this pr in the i18n channel in discord, maybe some from there will look at the translations

…context for new packages

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@i18n/locales/cs-CZ.json`:
- Line 39: The cs-CZ translation for the "changelog" key is misleading ("Otevřít
změny nového balíčku"); update the value for the "changelog" entry in
i18n/locales/cs-CZ.json (key: "changelog") to a neutral phrase that reflects
opening the changelog for the current package, e.g., "Otevřít changelog" or
"Otevřít změny balíčku", ensuring it no longer implies the package is new.

In `@i18n/locales/zh-TW.json`:
- Line 39: The "changelog" translation value currently reads "開啟變更日誌（針對新套件）",
which implies the shortcut is only for new packages; update the value for the
"changelog" key to remove the misleading qualifier and use "開啟變更日誌" so it
correctly reflects opening the changelog for the current package; locate the
"changelog" key in i18n/locales/zh-TW.json and replace its value accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e56b936e-6688-486f-ac4c-b92f6f747ff2

📥 Commits

Reviewing files that changed from the base of the PR and between 5ff06e6 and 710e3a6.

📒 Files selected for processing (9)

i18n/locales/cs-CZ.json
i18n/locales/hu-HU.json
i18n/locales/it-IT.json
i18n/locales/ja-JP.json
i18n/locales/pl-PL.json
i18n/locales/ta-IN.json
i18n/locales/tr-TR.json
i18n/locales/zh-CN.json
i18n/locales/zh-TW.json

✅ Files skipped from review due to trivial changes (5)

i18n/locales/zh-CN.json
i18n/locales/hu-HU.json
i18n/locales/pl-PL.json
i18n/locales/tr-TR.json
i18n/locales/ja-JP.json

🚧 Files skipped from review as they are similar to previous changes (2)

i18n/locales/ta-IN.json
i18n/locales/it-IT.json

coderabbitai · 2026-06-08T19:31:45Z

    "settings": "Otevřít nastavení",
    "compare": "Otevřít porovnání",
    "compare_from_package": "Otevřít porovnání (předvyplněno aktuálním balíčkem)",
+    "changelog": "Otevřít změny nového balíčku",


⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Translation may be misleading.

The Czech translation "Otevřít změny nového balíčku" (Open changes of new package) incorrectly suggests this shortcut only applies to new packages. According to the PR objectives, the - shortcut opens the changelog tab for the current package being viewed, regardless of whether it's new. Consider revising to "Otevřít changelog" or "Otevřít změny balíčku" (without "nového").

As noted in the PR comments, contributors are encouraged to translate only languages they're familiar with, and native speakers are preferable for ensuring translation accuracy.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@i18n/locales/cs-CZ.json` at line 39, The cs-CZ translation for the "changelog" key is misleading ("Otevřít změny nového balíčku"); update the value for the "changelog" entry in i18n/locales/cs-CZ.json (key: "changelog") to a neutral phrase that reflects opening the changelog for the current package, e.g., "Otevřít changelog" or "Otevřít změny balíčku", ensuring it no longer implies the package is new.

gameroman

I'd recommend to not adding translations for the languages you are not familiar with and wait until someone who does adds them later

… familiar)

BittuBarnwal7479 · 2026-06-08T19:53:57Z

I'd recommend to not adding translations for the languages you are not familiar with and wait until someone who does adds them later

I've removed the unverified translations and kept the change focused on the original fix.

feat: add changelog shortcut in search help and localize in multiple …

48582ac

…languages

vercel Bot deployed to Preview – npmx.dev June 7, 2026 18:57 View deployment

ghostdevv requested changes Jun 7, 2026

View reviewed changes

ghostdevv changed the title ~~feat: add Missing "Open changelog" shortcut in Keyboard Shortcuts search section~~ fix: add missing changelog entry in keyboard shortcuts menu Jun 7, 2026

WilcoSp suggested changes Jun 8, 2026

View reviewed changes

fix(i18n): update changelog label to "Open wijzigingenoverzicht" in D…

5ff06e6

…utch locale

vercel Bot deployed to Preview – npmx.dev June 8, 2026 19:20 View deployment

WilcoSp approved these changes Jun 8, 2026

View reviewed changes

fix(i18n): update changelog labels for multiple languages to clarify …

710e3a6

…context for new packages

coderabbitai Bot reviewed Jun 8, 2026

View reviewed changes

gameroman requested changes Jun 8, 2026

View reviewed changes

fix(i18n): remove changelog label from multiple language locales (not…

a248e80

… familiar)

vercel Bot deployed to Preview – npmx.dev June 8, 2026 19:53 View deployment

Uh oh!

Conversation

BittuBarnwal7479 commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercel Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Uh oh!

github-actions Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

codecov Bot commented Jun 7, 2026

Codecov Report

Uh oh!

ghostdevv left a comment

Choose a reason for hiding this comment

Uh oh!

BittuBarnwal7479 commented Jun 7, 2026

Uh oh!

WilcoSp left a comment

Choose a reason for hiding this comment

Uh oh!

WilcoSp Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

BittuBarnwal7479 Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

WilcoSp left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gameroman left a comment

Choose a reason for hiding this comment

Uh oh!

BittuBarnwal7479 commented Jun 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BittuBarnwal7479 commented Jun 7, 2026 •

edited

Loading

vercel Bot commented Jun 7, 2026 •

edited

Loading

coderabbitai Bot commented Jun 7, 2026 •

edited

Loading

github-actions Bot commented Jun 7, 2026 •

edited

Loading