Skip to content

fix(i18n): updated Dutch translations - #3070

Merged
gameroman merged 15 commits into
npmx-dev:mainfrom
WilcoSp:nl/july2026
Aug 5, 2026
Merged

fix(i18n): updated Dutch translations#3070
gameroman merged 15 commits into
npmx-dev:mainfrom
WilcoSp:nl/july2026

Conversation

@WilcoSp

@WilcoSp WilcoSp commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

🧭 Context

This pr updates dutch to be up to date with recent changes.

📚 Description

  • fixed an issue where @:tagline didn't resolve to the tagline.
  • fixed the casing for "Wijzigingen" (changelog) for package header & changed "wijzigingenoverzicht" to "wijzigingen" in the keyboard shortcuts modal.
  • updated "package.trends.embedding.tip" to be up to date with the current English version.
  • added translations for sponsor page
    • for sponsors_page.tiers.custom I've changed in Dutch to "to discus" as it's in Dutch more common
  • added translations voor foreground shade.
  • added translations for other new translations for already existing segments.

ai use

I did use some chatgpt & gemini to help translate for the long texts or where I was questioning myself what would be the best translation

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview Aug 5, 2026 8:00am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Aug 5, 2026 8:00am
npmx-lunaria Ignored Ignored Aug 5, 2026 8:00am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Summary by CodeRabbit

  • Improvements
    • Updated Dutch translations across sponsorship, changelog, theme settings, package views, trends, embeds, and code-rendering messages.
    • Added Dutch content for the sponsors page, including headings, descriptions, calls to action, sponsorship metrics, and tier labels.
    • Improved Dutch messaging for missing content, accessibility descriptions, chart controls, theme announcements, and trend watermarks.

Walkthrough

The Dutch locale adds and updates strings for navigation, themes, noodles, packages, trends, embedding, code warnings, and a new sponsorship page with footer labelling and tier content.

Changes

Dutch locale updates

Layer / File(s) Summary
Core UI translation updates
i18n/locales/nl.json
Command palette, theme, noodles, and package translation keys are added or revised.
Chart and code-rendering copy
i18n/locales/nl.json
Trends chart, watermark, embedding, date-range, and code-rendering translations are expanded or updated.
Sponsorship page translations
i18n/locales/nl.json
The footer sponsorship label and sponsors_page content, including headings, CTAs, metrics, pricing, and tiers, are added.

Possibly related PRs

Suggested reviewers: ghostdevv

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: updating Dutch translations.
Description check ✅ Passed The description directly explains the Dutch translation updates and the specific terminology changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/nl.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@i18n/locales/nl.json`:
- Line 44: Update the nl.json changelog translation from the singular “Open
wijziging” to a plural label matching the existing “Wijzigingen” terminology,
such as “Wijzigingen openen” or “Open wijzigingen”.
- Line 194: Update the Dutch translation for foreground_theme_changed and the
corresponding entries around the referenced range to consistently use
“Voorgrondthema” terminology and announce “Voorgrondthema ingesteld op {theme}.”
instead of referring to a foreground colour.
- Around line 1323-1329: Update the adoption.description translation under the
adoption metric to remove the leading typo, changing “EGrafieken” to “Grafieken”
while preserving the rest of the text.
- Line 1094: Update the Dutch translation value for the binary_rendering_warning
key to use grammatically correct wording, such as “Bestandstype "{contentType}"
kan niet worden weergegeven.” Preserve the existing {contentType} placeholder.
- Line 652: Update the other_dependencies translation in the locale data from
the ambiguous “Anderen” label to the explicit “Andere dependencies” label.
- Around line 1299-1307: Standardize the Dutch form of address across the
sponsorship-page translations, including the visible keys what_support_means and
what_this_means_for_you. Choose either formal or informal address and update all
possessive and personal pronouns consistently, including “uw/u” and
“jouw/je/Je”.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4afd6cea-caef-41a9-a0de-ec40e89146ac

📥 Commits

Reviewing files that changed from the base of the PR and between 33d3592 and e8fb730.

📒 Files selected for processing (1)
  • i18n/locales/nl.json

Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json
@gameroman gameroman added i18n Related to internationalization needs review This PR is waiting for a review from a maintainer labels Jul 29, 2026
@WilcoSp

WilcoSp commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

hey @larsdouweschuitema would you like to review the new & changed translations for Dutch?

@larsdouweschuitema

larsdouweschuitema commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

hey @larsdouweschuitema would you like to review the new & changed translations for Dutch?

Hi! Thanks for the work. Yes I will help you by reviewing this work :)

@WilcoSp

WilcoSp commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks Lars

@WilcoSp WilcoSp changed the title fix(i18n): update Dutch fix(i18n): updated Dutch translations Jul 30, 2026

@larsdouweschuitema larsdouweschuitema left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. I had a busy week trying to finish work before my holidays and only had time to review it now.

Thanks for the update. I am pre-approving. Although I don't know what the contribution convention here is. These changes I generally pre-approve, but happy to adjust my workflow if things are done differently over here. I do this mainly because the scope is small, overall the copy is looking great and risk of regressions are smalll.

I have made a few copy proposals. Let me know what you think :)

Good job! 🚀

Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json Outdated
Comment thread i18n/locales/nl.json
"title": "Sponsorpakketten",
"per_month": "/maand",
"custom": "In overleg",
"silver": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, maybe a bit outside of the scope of this PR and a bit awkward: All languages have a single property and I think we could have started with a more flat structure e.g. silver_name before introducing this structure. For all languages we have only a single property and now we have a bit of an awkward situation. Feel free to ignore though. Just wanted to point out my thought about it :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I also don't know why it was made this way, the only thing I think of is to future proof it in case a description is going to be added

WilcoSp and others added 7 commits August 5, 2026 09:51
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
glad you keep finding these, I keep over reading the "je"/"jouw" thanks to my work where we do use "je"/"jouw"

Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
@WilcoSp

WilcoSp commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

I've applied the suggested changes from Lars, in my opinion this pr can be merged

@larsdouweschuitema

Copy link
Copy Markdown
Contributor

I've applied the suggested changes from Lars, in my opinion this pr can be merged

Thanks for the quick updates. Ready to go indeed!

@gameroman gameroman removed the needs review This PR is waiting for a review from a maintainer label Aug 5, 2026
@gameroman
gameroman added this pull request to the merge queue Aug 5, 2026
Merged via the queue into npmx-dev:main with commit 4b40e42 Aug 5, 2026
24 checks passed
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Related to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants