fix(i18n): updated Dutch translations - #3070
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Dutch locale adds and updates strings for navigation, themes, noodles, packages, trends, embedding, code warnings, and a new sponsorship page with footer labelling and tier content. ChangesDutch locale updates
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/locales/nl.json`:
- Line 44: Update the nl.json changelog translation from the singular “Open
wijziging” to a plural label matching the existing “Wijzigingen” terminology,
such as “Wijzigingen openen” or “Open wijzigingen”.
- Line 194: Update the Dutch translation for foreground_theme_changed and the
corresponding entries around the referenced range to consistently use
“Voorgrondthema” terminology and announce “Voorgrondthema ingesteld op {theme}.”
instead of referring to a foreground colour.
- Around line 1323-1329: Update the adoption.description translation under the
adoption metric to remove the leading typo, changing “EGrafieken” to “Grafieken”
while preserving the rest of the text.
- Line 1094: Update the Dutch translation value for the binary_rendering_warning
key to use grammatically correct wording, such as “Bestandstype "{contentType}"
kan niet worden weergegeven.” Preserve the existing {contentType} placeholder.
- Line 652: Update the other_dependencies translation in the locale data from
the ambiguous “Anderen” label to the explicit “Andere dependencies” label.
- Around line 1299-1307: Standardize the Dutch form of address across the
sponsorship-page translations, including the visible keys what_support_means and
what_this_means_for_you. Choose either formal or informal address and update all
possessive and personal pronouns consistently, including “uw/u” and
“jouw/je/Je”.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4afd6cea-caef-41a9-a0de-ec40e89146ac
📒 Files selected for processing (1)
i18n/locales/nl.json
|
hey @larsdouweschuitema would you like to review the new & changed translations for Dutch? |
Hi! Thanks for the work. Yes I will help you by reviewing this work :) |
|
Thanks Lars |
There was a problem hiding this comment.
Sorry for the delayed review. I had a busy week trying to finish work before my holidays and only had time to review it now.
Thanks for the update. I am pre-approving. Although I don't know what the contribution convention here is. These changes I generally pre-approve, but happy to adjust my workflow if things are done differently over here. I do this mainly because the scope is small, overall the copy is looking great and risk of regressions are smalll.
I have made a few copy proposals. Let me know what you think :)
Good job! 🚀
| "title": "Sponsorpakketten", | ||
| "per_month": "/maand", | ||
| "custom": "In overleg", | ||
| "silver": { |
There was a problem hiding this comment.
Nitpick, maybe a bit outside of the scope of this PR and a bit awkward: All languages have a single property and I think we could have started with a more flat structure e.g. silver_name before introducing this structure. For all languages we have only a single property and now we have a bit of an awkward situation. Feel free to ignore though. Just wanted to point out my thought about it :)
There was a problem hiding this comment.
yeah, I also don't know why it was made this way, the only thing I think of is to future proof it in case a description is going to be added
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
glad you keep finding these, I keep over reading the "je"/"jouw" thanks to my work where we do use "je"/"jouw" Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
|
I've applied the suggested changes from Lars, in my opinion this pr can be merged |
Thanks for the quick updates. Ready to go indeed! |
Co-authored-by: Lars Douwe Schuitema <larsschuitema@funda.nl>
🧭 Context
This pr updates dutch to be up to date with recent changes.
📚 Description
@:taglinedidn't resolve to the tagline.sponsors_page.tiers.customI've changed in Dutch to "to discus" as it's in Dutch more commonai use
I did use some chatgpt & gemini to help translate for the long texts or where I was questioning myself what would be the best translation