Add CircleCI config and GitHub workflow to redirect to CircleCI#90
Add CircleCI config and GitHub workflow to redirect to CircleCI#90melissawm wants to merge 2 commits intonumpy:mainfrom
Conversation
Appropriate tokens need to be set on the repo side.
Kai-Striega
left a comment
Kai-Striega
left a comment
There was a problem hiding this comment.
Looks good to me, with a couple of questions. Thanks!
| poetry install | ||
| python -m pip install sphinx pydata-sphinx-theme | ||
| cd docs; make html |
There was a problem hiding this comment.
I think this can be simplified with poetry. Poetry has the concept of dependency groups meaning we can install the doc dependencies by running poetry install --with doc. I think we will be required to change the makefile to work with poetry if we do go down that route though.
There was a problem hiding this comment.
I am trying but even with the right dependencies in the docs group of the pyproject.toml file, when I do "poetry install --with docs" nothing is installed. To be fair none of the other groups work for me either and "poetry install --with test" or "poetry install --with bench" also don't do anything. I'm really not familiar with poetry so I wonder if I'm missing a step somewhere...
There was a problem hiding this comment.
The argument should be docs, not doc (note the extra s) - that's on me, I got it wrong in the above comment. It might be that you have installed all the dependencies already in your local environment, which is why it's not installing anything else.
There was a problem hiding this comment.
Yeah, I figured the doc vs docs thing looking at
numpy-financial/pyproject.toml
Line 49 in 1656639
Still, it doesn't work:
➜ numpy-financial git:(setup-circle) poetry install --with docs
Installing dependencies from lock file
No dependencies to install or update
Installing the current project: numpy-financial (1.1.0.dev0)
➜ numpy-financial git:(setup-circle) cd doc
➜ doc git:(setup-circle) make html
/bin/sh: linha 1: sphinx-build: comando não encontrado # "command not found"
make: *** [Makefile:20: html] Error 127
|
Hi 👋🏻 not sure if I can do anything to push this forward? Feel free to close if this is not useful. Cheers! |
2 participants
Appropriate tokens need to be set on the repo side.