fix: lua_ls no longer exists in mason registry #1847
Conversation
veonim
changed the title
|
This can be fixed by adding Personally, I think this is the cleaner way because it bridges the gap between lspconfig and mason and allows the installation and auto-enabling of lsp servers by the actual configuration name so maintaining the project will be easier over time. |
|
@vimjeremy Yeah, it did handled that perfectly. Thanks for suggestion, updated the PR |
| -- Mason must be loaded before its dependents so we need to set it up here. | ||
| -- NOTE: `opts = {}` is the same as calling `require('mason').setup({})` | ||
| { 'mason-org/mason.nvim', opts = {} }, | ||
| { 'mason-org/mason-lspconfig.nvim', opts = {} }, |
There was a problem hiding this comment.
It might need a brief explanation of why its needed.
It turns out, that's not necessarily clear, especially for newcomers, e.g.
https://www.reddit.com/r/neovim/comments/1pnqyi8/please_clarify_the_purpose_of_masonlspconfig/
There was a problem hiding this comment.
mason-lspconfig enables auto-enable and enables the installing of LSP servers by configuration name.
eg. in nvim-lspconfig the configurations for lua-language-server is named lua_ls
so with mason-lspconfig you can :MasonInstall lua_ls instead of lua-language-server which is actually done in kickstart.nvim
There was a problem hiding this comment.
Sorry for my confusing comment then 😅
I mean it seems reasonable to supply this dependency with a comment explaining why it's needed, to avoid removing it again without a good reason veonim@ad246eb
3 participants
I just did a fresh install today and was thrown into an error that lua_ls not found.
Switched to lua-language-server, making this PR for base repository because other people might face this issue.