-
Notifications
You must be signed in to change notification settings - Fork 2
fix: Add some more RETURNING clause tests, and fix JSON encoding and … #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
011a05a
fix: Add some more RETURNING clause tests, and fix JSON encoding and …
ocean f4f0265
feat: Add ecto_sqlite3 compatibility test suite
ocean 47125bf
docs: Add comprehensive ecto_sqlite3 compatibility testing documentation
ocean ab0c6f3
fix: Switch ecto_sqlite3 compat tests to manual table creation
ocean 4a2ddf9
docs: Update compatibility testing status and findings
ocean 71cd4eb
docs: Add comprehensive session summary
ocean 89402b5
Fix ecto_libsql compatibility tests - Timestamps, JSON, and BLOB tests
ocean 36795a0
Add comprehensive session summary for compatibility test fixes
ocean 44c813f
Apply formatter fixes to all modified files
ocean 79c5443
Add datetime roundtrip assertions in type_compatibility_test
ocean 4dd6aac
fix: Add per-test cleanup and timestamp columns to CRUD compatibility…
ocean 51ff6be
docs: Add SQLite-specific query limitations and compatibility testing…
ocean 0c08926
Fix: Handle :serial and :bigserial types in migrations
ocean ea3b047
refactor: Add explicit nil handling in json_encode/1 function
ocean 6419a18
refactor: Simplify redundant assertion condition in returning_test.exs
ocean 12c4d50
style: Format ecto_sqlite3_returning_debug_test.exs for code style co…
ocean dd49e41
docs: Add completion summary for CI fixes
ocean 36f534c
fix: Remove unused variables and imports in test files
ocean c24a071
refactor: Improve AccountUser schema with associations and validation
ocean ccab556
refactor: Address code review feedback and improve test quality
ocean 95a3ae2
feat: Add CHECK constraint support for column-level constraints
ocean f484d4f
fix: Add datetime microsecond type loading support
ocean 441fc97
docs: Update CHANGELOG with summary of unreleased changes
ocean d38d7bf
feat: Add comprehensive type loader/dumper support
ocean e5d0cfb
chore: Remove unneeded docs
ocean 9dcdddb
chore: Sync beads with type enhancement issues
ocean 7d5f7c2
docs: Fix incorrect BLOB null byte claim and add missing comma
ocean d160e3b
test: Fix microsecond precision assertions in datetime tests
ocean a5f565f
test: Add assertion for update result in timestamp compat test
ocean e436678
test: Remove debug IO.inspect calls from timestamp compat test
ocean ef97b80
refactor: Improve test reliability and error handling
ocean fffd42e
fix: Add nil-handling to date, time, and bool encode functions
ocean 232a9f6
refactor: Improve test accuracy in type loader/dumper tests
ocean bfb0a79
refactor: Address code review feedback for test quality and documenta…
ocean f363618
Fix datetime_decode to handle timezone-aware ISO8601 strings
ocean 8b1d2de
Add Ecto dumper path tests for nil value encoding
ocean 65dec2b
Update decimal SQL query assertions to accept both numeric and string…
ocean 8ee23c9
Strengthen microsecond preservation tests and fix DB collision issue
ocean 63d3db4
tests: Improve type tests
ocean 81b2cf3
Add microsecond assertions for datetime_usec fields in round-trip test
ocean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ## Timestamp format in compatibility tests | ||
|
|
||
| Timestamps are being returned as integers (1) instead of NaiveDateTime when data is queried. The issue is that column type `DATETIME` in manual CREATE TABLE statements needs to be changed to `TEXT` with ISO8601 format to match Ecto's expectations. | ||
|
|
||
| **Affected tests:** | ||
| - `test/ecto_sqlite3_timestamps_compat_test.exs` | ||
| - Tests that query timestamp fields in other compatibility tests | ||
|
|
||
| **Impact:** Timestamp deserialization fails, causing multiple tests to fail | ||
|
|
||
| --- | ||
|
|
||
| ## Test isolation in compatibility tests | ||
|
|
||
| Tests within the same module are not properly isolated. Multiple tests accumulate data affecting each other. Test modules currently share the same database file within a module run. | ||
|
|
||
| **Impact:** Tests fail when run in different orders or when run together vs separately | ||
|
|
||
| --- | ||
|
|
||
| ## SQLite query feature limitations documentation | ||
|
|
||
| Some SQLite query features are not supported: `selected_as()` / GROUP BY with aliases and `identifier()` fragments. These appear to be SQLite database limitations, not adapter issues. | ||
|
|
||
| **Impact:** 2-3 tests fail due to feature gaps in SQLite itself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| el-1p2 | ||
| el-b21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.