Open
Conversation
Kay-Zee
approved these changes
Mar 20, 2026
Member
Author
|
This PR documents these values as they are now. Discussion on whether they should change are in this thread: https://flow-foundation.slack.com/archives/C08QF29F7TK/p1773783670640229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to make it clear that the total credit/debit balance fields differ from other balance tracking. In positions, we track a scaled balance, which can be converted to a true balance using a frequently-updated interest index.
The total balance fields are neither a scaled balance nor a true value. They represent actual in- and out-flows of tokens, and do not account for interest accrual. We expect them to relate to the reserve balances, but not to interest-adjust position balances.