Faster tests by harshach · Pull Request #24948 · open-metadata/OpenMetadata

harshach · 2025-12-22T08:28:43Z

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

…st workflows

+      - name: Install Ubuntu dependencies
+        if: steps.cache-output.outputs.exit-code == 0
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y unixodbc-dev python3-venv librdkafka-dev gcc libsasl2-dev build-essential libssl-dev libffi-dev \
+          librdkafka-dev unixodbc-dev libevent-dev jq
+          sudo make install_antlr_cli
+
+      - name: Build with Maven


+      - name: Build with Maven
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn -DskipTests clean install -pl '!openmetadata-ui,!openmetadata-docs,!openmetadata-docs-v1' -am
+
+      - name: Run Integration Tests (MySQL + Elasticsearch)


+      - name: Run Integration Tests (MySQL + Elasticsearch)
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn test -pl :openmetadata-integration-tests -Pmysql-elasticsearch
+
+      - name: Clean Up


+      - name: Install Ubuntu dependencies
+        if: steps.cache-output.outputs.exit-code == 0
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y unixodbc-dev python3-venv librdkafka-dev gcc libsasl2-dev build-essential libssl-dev libffi-dev \
+          librdkafka-dev unixodbc-dev libevent-dev jq
+          sudo make install_antlr_cli
+
+      - name: Build with Maven


+      - name: Build with Maven
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn -DskipTests clean install -pl '!openmetadata-ui,!openmetadata-docs,!openmetadata-docs-v1' -am
+
+      - name: Run Integration Tests (PostgreSQL + OpenSearch)


+      - name: Run Integration Tests (PostgreSQL + OpenSearch)
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn test -pl :openmetadata-integration-tests -Ppostgres-opensearch
+
+      - name: Clean Up


gitar-bot · 2025-12-27T03:43:27Z

Code Review 👍 Approved with suggestions

Major integration testing framework addition with comprehensive SDK enhancements. Well-structured parallel test infrastructure with only minor documentation concerns.

Suggestions 💡 2 suggestions

Code Quality: Migration tracker documentation still committed to repository

📄 openmetadata-integration-tests/TEST_MIGRATION_TRACKER.md

The file openmetadata-integration-tests/TEST_MIGRATION_TRACKER.md (244 lines) is a development tracking document that appears to be internal documentation for tracking the migration of tests from the old framework to the new one. This contains development notes, checkmarks, and progress tracking.

This type of documentation is typically maintained externally (in issues/PRs/project management tools) rather than committed to the repository. Having it in the codebase:

Creates maintenance burden to keep it updated
May become outdated and confusing for future contributors
Contains development progress that has no value once the migration is complete

Consider removing this file and tracking the migration status in the PR description or an external tracking issue instead.

Security: Test credentials hardcoded in bootstrap code

📄 openmetadata-integration-tests/src/test/java/org/openmetadata/it/bootstrap/TestSuiteBootstrap.java:83-91

The TestSuiteBootstrap contains hardcoded test credentials that, while only used in test environments, could be concerning:

private static final String ELASTIC_PASSWORD = "password";
private static final String FUSEKI_ADMIN_PASSWORD = "test-admin";

These are acceptable for test infrastructure, but consider:

Adding comments explicitly stating these are TEST-ONLY credentials
Document in the README that these should never be used in production contexts
Consider using environment variable overrides for CI environments if needed

This is low severity since these are clearly for test containers and won't be deployed to production, but the pattern should be documented to prevent confusion.

Resolved ✅ 2 resolved

Code Quality: Backup files (.bak, .backup, .bak2) still committed to repository

📄 openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java.backup 📄 openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java.bak 📄 openmetadata-sdk/src/main/java/org/openmetadata/sdk/client/OpenMetadataClient.java.bak 📄 openmetadata-sdk/src/main/java/org/openmetadata/sdk/client/OpenMetadataClient.java.bak2
Several backup files are still included in this PR, which should not be committed to version control:

openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java.backup

openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java.bak

openmetadata-sdk/src/main/java/org/openmetadata/sdk/client/OpenMetadataClient.java.bak

openmetadata-sdk/src/main/java/org/openmetadata/sdk/client/OpenMetadataClient.java.bak2

Impact: These files increase repository size unnecessarily, may cause confusion, and could potentially contain stale/incorrect code that shouldn't be referenced.

Suggested fix: Remove these backup files before merging:
git rm openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java.backup
git rm openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java.bak
git rm openmetadata-sdk/src/main/java/org/openmetadata/sdk/client/OpenMetadataClient.java.bak
git rm openmetadata-sdk/src/main/java/org/openmetadata/sdk/client/OpenMetadataClient.java.bak2
Also add these patterns to .gitignore:
*.bak
*.backup
*.bak2

Code Quality: Excessive migration tracking documentation files committed

📄 openmetadata-integration-tests/MIGRATION_AUDIT.md 📄 openmetadata-integration-tests/MIGRATION_STATUS.md 📄 openmetadata-integration-tests/TEST_MIGRATION_TRACKER.md
Multiple migration tracking and status documentation files are being added to the repository:

openmetadata-integration-tests/MIGRATION_AUDIT.md

openmetadata-integration-tests/MIGRATION_COMPLETE_SUMMARY.md

openmetadata-integration-tests/MIGRATION_REPORT.md

openmetadata-integration-tests/MIGRATION_STATUS.md

openmetadata-integration-tests/TEST_MIGRATION_TRACKER.md

openmetadata-integration-tests/TEST_MIGRATION_STATUS.md

openmetadata-integration-tests/TEST_MIGRATION_AUDIT.md

openmetadata-integration-tests/TEST_COVERAGE_GAP_ANALYSIS.md

openmetadata-integration-tests/SDK_CAPABILITIES_ANALYSIS.md

openmetadata-integration-tests/VALIDATION_FRAMEWORK_IMPLEMENTATION.md

openmetadata-integration-tests/VALIDATION_GAP_ANALYSIS.md

openmetadata-integration-tests/COMPLETE_MIGRATION_PLAN.md

ADDED_TESTS_SUMMARY.md

Impact: These appear to be internal development tracking documents that add significant noise to the repository. Most of this information would be better suited for a project tracking system (e.g., GitHub Issues, Jira) or should be consolidated into a single README.

Suggested fix: Consider keeping only the README.md which provides user-facing documentation about the test module. Remove or consolidate the tracking documents, or move them to a /docs/internal/ directory if they need to be preserved for historical reference.

What Works Well

Excellent Test Infrastructure Design: The TestSuiteBootstrap with LauncherSessionListener ensures containers start once per session, not per test class, enabling efficient parallel execution.

Clean Fluent SDK APIs: New fluent builders (DataContracts, AIApplications, TestCases, etc.) provide a readable, chainable API pattern that improves SDK usability significantly.

Robust Concurrency Handling: The MySQL deadlock fix (INSERT ... ON DUPLICATE KEY UPDATE replacing INSERT IGNORE) addresses a real production issue. TestNamespace isolation pattern ensures parallel tests don't interfere.

Well-Organized Module: The new openmetadata-integration-tests module is properly structured with Maven profiles for different database/search combinations, comprehensive documentation in README, and sensible defaults.

Recommendations

Consider adding explicit test-only comments around hardcoded credentials in bootstrap code to prevent any future confusion about their purpose.

Options

Auto-apply is off Gitar will not commit updates to this branch.
✅ Code review is on Gitar will review this change.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

`Auto-apply`	`✅ Code review`	`Compact`
`gitar auto-apply:on`	`gitar code-review:off`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)}

sonarqubecloud · 2025-12-27T04:10:41Z

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-12-27T05:43:56Z

Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

harshach added 5 commits December 22, 2025 00:16

Add Parallel tests using the new SDK

9582c7b

Make tests faster and use new SDK

f1c0d65

Add SDK based parallel tests

e470a51

Add SDK based parallel tests

292ae54

Fix from main

d9eabbb

harshach requested a review from a team as a code owner December 22, 2025 08:28

harshach temporarily deployed to test December 22, 2025 08:28 — with GitHub Actions Inactive

github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 22, 2025

harshach added 10 commits December 22, 2025 14:41

Add Fluen APIs for Tests

3444136

Add Fluen APIs for Tests

8df7412

Add missing Fluent APIs for SDK

c3a0b7b

Add missing Fluent APIs for SDK - Data Contracts

0ab97ca

Migrate all the integration tests to new module

45df27d

Migrate all the integration tests to new module

cea921c

Improve pagination test performance

16968c7

Fix tests

cd2a497

Migration Complete

eb5b0c1

Fix the code styling; add github workflows, fix tags parallel issues

315215a

harshach requested review from akash-jain-10 and tutte as code owners December 26, 2025 21:15

harshach had a problem deploying to test December 26, 2025 21:15 — with GitHub Actions Failure

Address comments

7403c10

harshach had a problem deploying to test December 26, 2025 23:34 — with GitHub Actions Failure

github-advanced-security AI found potential problems Dec 26, 2025

View reviewed changes

harshach had a problem deploying to test December 27, 2025 00:31 — with GitHub Actions Failure

rename env -> bootstrap for java package

a7090eb

harshach temporarily deployed to test December 27, 2025 00:53 — with GitHub Actions Inactive

Fix YAML syntax in playwright-sso-tests.yml and update integration te…

f8e88f2

…st workflows

harshach temporarily deployed to test December 27, 2025 03:40 — with GitHub Actions Inactive

harshach had a problem deploying to test December 27, 2025 03:40 — with GitHub Actions Failure

harshach temporarily deployed to test December 27, 2025 03:40 — with GitHub Actions Inactive

github-advanced-security AI found potential problems Dec 27, 2025

View reviewed changes

harshach merged commit ab53590 into main Dec 27, 2025
39 of 47 checks passed

harshach deleted the faster_tests_2 branch December 27, 2025 07:47

gitar-bot Bot mentioned this pull request Dec 27, 2025

Upgrade to Dropwizard 5x and Jetty 12.1 #24776

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Faster tests #24948

Faster tests #24948
harshach merged 20 commits intomainfrom
faster_tests_2

harshach commented Dec 22, 2025 •

edited by gitar-bot Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

gitar-bot Bot commented Dec 27, 2025 •

edited

Loading

What Works Well

Recommendations

Uh oh!

sonarqubecloud Bot commented Dec 27, 2025

Uh oh!

sonarqubecloud Bot commented Dec 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

harshach commented Dec 22, 2025 • edited by gitar-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

gitar-bot Bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Works Well

Recommendations

Uh oh!

sonarqubecloud Bot commented Dec 27, 2025

Quality Gate passed for 'open-metadata-ui'

Uh oh!

sonarqubecloud Bot commented Dec 27, 2025

Quality Gate passed for 'open-metadata-ingestion'

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

harshach commented Dec 22, 2025 •

edited by gitar-bot Bot

Loading

gitar-bot Bot commented Dec 27, 2025 •

edited

Loading