Fix jfr-events tests#2818
Merged
jaydeluca merged 1 commit intoopen-telemetry:mainfrom May 5, 2026
Merged
Conversation
laurit
approved these changes
May 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR fixes the jfr-events test setup so the module's tests can run under Kotlin DSL Gradle configuration, and updates JFR span test assertions to match the actual extracted collection values.
Changes:
- Update the Jacoco Kotlin DSL configuration to use the correct boolean property setter form.
- Adjust
JfrSpanProcessorTestassertions from scalar equality checks to collection-aware assertions. - Refine the scoped span test expectations for multi-event output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
jfr-events/src/test/java/io/opentelemetry/contrib/jfrevent/JfrSpanProcessorTest.java |
Updates test assertions to match AssertJ extraction behavior over event collections. |
jfr-events/build.gradle.kts |
Fixes Gradle Kotlin DSL Jacoco configuration so tests can execute correctly. |
Merged
via the queue into
open-telemetry:main
with commit May 5, 2026
27ac47b
23 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #2739 i was trying to run the tests locally and they were not working due to a bug in the gradle config beacuse Kotlin DSL requires the is-prefixed form for boolean properties.
Once the tests were fixed to run, they were failing, so i updated the assertions accordingly