Skip to content

Conversation

@jack-berg
Copy link
Member

Related to #6970.

This test prints out instances of shared internal code use. We could eventually remove all the detected instances, at which point we could fail the build instead of just printing.

But there's a long way to go. See this gist for the current state of affairs.

Note: I don't currently have a good way to tell when internal code is referenced for things like the SDK's implementation of of opentelemetry-api-incubating, which is switched to a compile dependency in #6944.

@codecov
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (62049e7) to head (b2eb978).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6978   +/-   ##
=========================================
  Coverage     90.15%   90.15%           
  Complexity     7476     7476           
=========================================
  Files           836      836           
  Lines         22550    22550           
  Branches       2224     2224           
=========================================
  Hits          20331    20331           
  Misses         1515     1515           
  Partials        704      704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg marked this pull request as ready for review January 9, 2026 20:51
@jack-berg jack-berg requested a review from a team as a code owner January 9, 2026 20:51
@jack-berg
Copy link
Member Author

Resurrecting this and marking ready for review @open-telemetry/java-approvers.

There have been a number of topics coming up lately that reinforce the need to avoid shared internal code. A couple that come to mind:

"opentelemetry-exporter-otlp-common",
"opentelemetry-exporter-sender-grpc-managed-channel",
"opentelemetry-exporter-sender-jdk",
"opentelemetry-exporter-sender-okhttp"));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the TODO list. All these modules use shared internal code.

In contrast, the list of modules which DO NOT use shared internal code is small:

  • opentelemetry-common
  • opentelemetry-context
  • opentelemetry-tracing-shim
  • opentelemetry-api
  • opentelemetry-extension-kotlin
  • opentelemetry-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant