Skip to content

Fix Handle null context in Baggage.fromContext() and Baggage.fromContextOrNull() - #8667

Open
NithinU2802 wants to merge 2 commits into
open-telemetry:mainfrom
NithinU2802:fix/baggage-null-context-handling
Open

Fix Handle null context in Baggage.fromContext() and Baggage.fromContextOrNull()#8667
NithinU2802 wants to merge 2 commits into
open-telemetry:mainfrom
NithinU2802:fix/baggage-null-context-handling

Conversation

@NithinU2802

Copy link
Copy Markdown
Contributor

In Baggage, to add null checks to Baggage.fromContext(context) and Baggage.fromContextOrNull(context) with log using ApiUsageLogger and for Baggage.fromContext(context) now returns empty() when the context is null, also for Baggage.fromContextOrNull(context) returns null. Additionally, added unit tests to cover these scenarios.

I'm happy to update any changes if needed.

Closes #8665

@NithinU2802
NithinU2802 requested a review from a team as a code owner July 28, 2026 11:36
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 28, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on maintainers · refreshed 2026-08-07 02:17 UTC

Merge when ready.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.46%. Comparing base (ff91c02) to head (195ebde).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8667      +/-   ##
============================================
- Coverage     91.46%   91.46%   -0.01%     
- Complexity    10456    10458       +2     
============================================
  Files          1021     1021              
  Lines         27647    27653       +6     
  Branches       3242     3242              
============================================
+ Hits          25288    25293       +5     
  Misses         1616     1616              
- Partials        743      744       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread api/all/src/main/java/io/opentelemetry/api/baggage/Baggage.java Outdated
…l and fromContextOrNull_null tests, and add LogCapturer assertions

@jkwatson jkwatson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me

@NithinU2802

Copy link
Copy Markdown
Contributor Author

Hi @jack-berg, could you please review this PR once you get a chance.

@opentelemetry-pr-dashboard

Copy link
Copy Markdown

Hi @NithinU2802 — just a friendly reminder that this pull request is waiting on you.

There are still items that need your attention. See the dashboard status comment for the full list. You don't need to push a code change to hand it back — replying to move each discussion forward is enough, whether that's answering a question, explaining why no change is needed, or asking a follow-up. The dashboard then automatically routes it back to reviewers.

If you believe this pull request is incorrectly routed as waiting on the author, comment /dashboard route:reviewers to route it from waiting on the author to waiting on reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix to add null handling to Baggage.fromContext() and Baggage.fromContextOrNull()

3 participants