Skip to content

chore(celery): type getter and harden utility helpers#4505

Open
diogosilva30 wants to merge 5 commits intoopen-telemetry:mainfrom
diogosilva30:chore/celery-housekeeping
Open

chore(celery): type getter and harden utility helpers#4505
diogosilva30 wants to merge 5 commits intoopen-telemetry:mainfrom
diogosilva30:chore/celery-housekeeping

Conversation

@diogosilva30
Copy link
Copy Markdown
Contributor

@diogosilva30 diogosilva30 commented Apr 29, 2026

Description

Split out of #4439.

This PR keeps only the Celery housekeeping changes:

  • type CeleryGetter and normalize its returned values
  • add null guards and helper typing in utils.py
  • refine utility helper protocols and context aliases to match actual call sites
  • update getter tests to match the typed behavior
  • add a Sphinx nitpick exception for celery.worker.request.Request used in the documented getter type annotation

Testing

  • uv run tox -e py311-test-instrumentation-celery -- -q
  • uv run tox -e docs -- -W

@diogosilva30 diogosilva30 marked this pull request as draft April 29, 2026 16:36
@diogosilva30 diogosilva30 marked this pull request as ready for review May 5, 2026 14:45
@diogosilva30 diogosilva30 requested a review from a team as a code owner May 5, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant