opamp-client: support text effective config bodies#4536
Open
pmcollins wants to merge 2 commits intoopen-telemetry:mainfrom
Open
opamp-client: support text effective config bodies#4536pmcollins wants to merge 2 commits intoopen-telemetry:mainfrom
pmcollins wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
herin049
approved these changes
May 6, 2026
also add PR# to changelog
JWinermaSplunk
approved these changes
May 6, 2026
Contributor
JWinermaSplunk
left a comment
JWinermaSplunk
left a comment
There was a problem hiding this comment.
Did we want to add coverage for a non serializable value with content type application/json?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for building OpAMP effective config messages from non-JSON text or bytes bodies. This allows callers to report effective configuration with MIME types such as
text/plain, while preserving the existingapplication/jsonbehavior.This aligns with the OpAMP spec's
AgentConfigFilemodel, wherebodyis raw bytes andcontent_typedescribes those bytes.Addresses #4535
Type of change
How Has This Been Tested?
Added OpAMP unit tests.
text/plaineffective config bodiescontent_typeand bodyDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.