google-genai: simplify monkey patched code to not need to handle dict cases#4541
Closed
aabmass wants to merge 1 commit into
Closed
google-genai: simplify monkey patched code to not need to handle dict cases#4541aabmass wants to merge 1 commit into
aabmass wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors
opentelemetry-instrumentation-google-genaiby instantiating the SDK's own Pydantic models (_GenerateContentParameters) early in the wrappers.This coerces user inputs (
configandcontents) immediately, allowing us to completely eliminate complex recursive dict-handling logic, redundant type-checking helpers, and obsolete imports (ToolUnionDict,ToolListUnionDict,ContentUnionDict) across the package. Legacy prompt logging formats are preserved to maintain backwards compatibility.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.