Conversation
herin049
approved these changes
Sep 9, 2026
lzchen
approved these changes
Sep 10, 2026
Contributor
|
Please rename changelog for the PR not the ISSUE. ( |
Pull request dashboard statusWaiting on maintainers · refreshed 2026-09-14 18:43 UTC Merge when ready. Status above doesn't look right?
|
Author
|
@lzchen Thanks for catching that, have renamed the changelog accordingly |
hectorhdzg
approved these changes
Sep 14, 2026
lzchen
enabled auto-merge
September 15, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, passing a negative value for max_value_len when initializing BoundedAttributes leads to Python string slicing (value[:max_value_len]) chopping characters off the end of strings instead of enforcing length limits, while logging misleading warning messages.
There was no check for a negative value, this PR adds this to the BoundedAttributes constructor.
Fixes #5646
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Before
No ValueError is raised during
__init__. The string is truncated unexpectedly from the right ({'test_key': 'hello wor'}), and an invalid warning log is emitted (String attribute value exceeds max length of -2, truncating.).After
Does This PR Require a Contrib Repo Change?
Checklist: