Repository navigation
InstanceLibrary rejects a missing instance folder before it can download it #185
Description
Activity
Two related gaps, found reviewing the stack that fixes the validator (#188), and left for whoever picks this up:
postSetInstanceLibraryLocationdecides whether to download from~isfolder(obj.InstanceLibraryLocation) || ~isRecordedCommitCurrent(...), butdownloadRepositoryalways writes to the default target. For a caller-named location that exists and whose recorded commit reads as stale, that downloads into the default location whileInstanceLibraryLocationkeeps pointing at the custom folder. fix: report what a controlled instance lookup cannot resolve #188 rejects a custom location that holds no version folder before construction, which narrows this, but a custom location that holds versions still reaches it.UseGit=trueselects a branch whose only statement is a commented-outpullRepositorycall, so it disables the download and does nothing else. The help text ongetSingletonsays so; the option should either do what its name says or go.
🤖 Generated with Claude Code
Problem
InstanceLibrary.getSingletondeclares itsfolderPathargument with{mustBeFolder}, defaulting toPaths.LocalInstanceFolder, and the class constructor declares the same. On a fresh installation that folder does not exist yet, so the validator rejects the call before the constructor runs:The constructor is written for exactly this case:
postSetInstanceLibraryLocationdownloads the repository when~isfolder(obj.InstanceLibraryLocation). That branch is unreachable, because the validator runs first. The download only happens today becausesetup.mcallsdownloadControlledInstancesseparately, and an installed toolbox never runssetup.m. A user of the .mltbx whose first call touches controlled instances gets a validation error instead of a download.Fix
Drop
mustBeFolderfrom both signatures, or validate after the download has had its chance. Since #184 the location is resolved to an absolute path when it is set, so a folder that does not exist yet is a well defined place to download into.🤖 Generated with Claude Code