Skip to content

getControlledInstance guesses instance folder names and gets them wrong #186

Description

@ehennestad

Problem

getControlledInstance builds the path to an instance file from the type name, in getRelativeInstanceFileParts. For the core module it pluralizes with schemaName + "s"; for sands it uses a folder called graphStructures.

Neither matches upstream. Accessibility instances live in accessibilities, so the function asks for accessibilitys and gets a 404 today:

https://raw.githubusercontent.com/openMetadataInitiative/openMINDS_instances/main/instances/latest/accessibilitys/directVirtualOpenAccess.jsonld

graphStructures does not exist in any version of the instance library. The sands instances are in parcellationEntities, anatomicalAtlases and their siblings at the top level.

This is the class of bug #184 removed from InstanceLibrary: folder names are pluralized type names, upstream renames them, and no rule derives them from the type. #184 resolved it there by reading the @type each document declares. getControlledInstance should find a file through the InstanceLibrary table rather than construct a path to it, and the raw GitHub fallback should go with the construction. #128 plans to replace the function with a bundled resolver, which would close this too.

🤖 Generated with Claude Code

Activity

  1. added 2 commits that reference this issue on Sep 11, 2026
    8a1d4c4
    26645cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions