Fix streamed citation annotation conversion - #129
Open
nathancooperjones wants to merge 1 commit into
Open
Conversation
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Normalizing Pydantic event-specific annotation models to plain data before validating against ChatKit's structurally equivalent response union is the right compatibility boundary. It avoids coupling conversion to the exact generated model class while still letting the existing TypeAdapter enforce the annotation schema. The regression reproduces the cross-module URL-citation case rather than weakening validation globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
OpenAI 3.x can deserialize a streamed annotation into an event-specific Pydantic model. ChatKit validates that object against a structurally identical union from another module. Pydantic rejects the different model class before ChatKit can convert the citation.
Test plan
The repository-wide format check also reports four existing failures in unchanged files.