[codex] Consolidate shared prompts in codex-prompts#25151
Merged
Conversation
anp-oai
force-pushed
the
codex/core-split-review-prompts
branch
2 times, most recently
from
c8215cd to
4064fc1
Compare
anp-oai
force-pushed
the
codex/core-split-review-prompts
branch
from
4064fc1 to
388c807
Compare
anp-oai
changed the title
anp-oai
force-pushed
the
codex/core-split-review-prompts
branch
from
388c807 to
2ce38ba
Compare
anp-oai
commented
May 29, 2026
anp-oai
commented
May 29, 2026
anp-oai
force-pushed
the
codex/core-split-review-prompts
branch
3 times, most recently
from
c29c949 to
c648d4f
Compare
anp-oai
changed the title
bolinfest
approved these changes
Jun 1, 2026
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
anp-oai
force-pushed
the
codex/core-split-review-prompts
branch
from
c648d4f to
e99b34a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex_coreis consistently a bottleneck for incremental builds during iteration. The simplest fix is to make the crate smaller.Summary
codex-coreowns several reusable prompt renderers and static prompt assets, which makes the crate harder to split apart.Rename
codex-review-promptstocodex-promptsand move shared review, goal, permissions, compaction, realtime, hierarchical AGENTS.md, andapply_patchprompts into it. Move prompt-only tests and update consumers andCODEOWNERS.Validation
just test -p codex-prompts -p codex-apply-patchjust test -p codex-core prompt_caching