-
Notifications
You must be signed in to change notification settings - Fork 6.9k
fix parallel tool calls #7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parallel tool calls #7956
Changes from all commits
9a753a9
38d021e
9b4474f
184c29e
b0b6235
739f2ac
f6d3299
4184ad7
cfa7258
f60c36f
fc83de1
fbadb2b
2bcef8b
306d4e5
0600686
991c913
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,7 @@ impl ToolCallRuntime { | |
|
|
||
| #[instrument(skip_all, fields(call = ?call))] | ||
| pub(crate) fn handle_tool_call( | ||
| &self, | ||
| self, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why did this change?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so we don't have to the tool runtime in a short lived function |
||
| call: ToolCall, | ||
| cancellation_token: CancellationToken, | ||
| ) -> impl std::future::Future<Output = Result<ResponseInputItem, CodexErr>> { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.