feat: Add on_stream to agents as tools #2169
Conversation
src/agents/agent.py
Outdated
| event: StreamEvent | ||
| """The streaming event from the nested agent run.""" | ||
|
|
||
| agent_name: str |
There was a problem hiding this comment.
instead of agent_name, why not pass the Agent object?
There was a problem hiding this comment.
yeah this is true. i will revisit the properties in this object
| maybe_result = on_stream(payload) | ||
| if inspect.isawaitable(maybe_result): | ||
| await maybe_result |
There was a problem hiding this comment.
this can be kinda bad since on_stream will block you from going to the next event. fine for now, but we should consider a queue based pattern where we write to a queue from here and the consumer reads from the queue, and we aren't blocking
There was a problem hiding this comment.
good call; actually i made these executions async in the TS SDK. so will make this more efficient and consistent.
seratch
force-pushed
the
agent-as-tool-streaming
branch
2 times, most recently
from
573e483 to
24088d3
Compare
seratch
force-pushed
the
agent-as-tool-streaming
branch
from
24088d3 to
94d2239
Compare
|
@codex review this PR again |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/agents/agent.py
Outdated
| payload: AgentToolStreamEvent = { | ||
| "event": event, | ||
| "agent": self, | ||
| "tool_call": getattr(context, "tool_call", None), |
There was a problem hiding this comment.
When a tool-invoked agent hands off to another agent, run_result.stream_events() will emit AgentUpdatedStreamEvent and subsequent events belong to the new agent, but the payload always sets agent to self (the original tool agent). In runs that include handoffs, this misattributes events and can break on_stream handlers that route or label output by the emitting agent, because they will never see the actual current agent after a handoff. Consider populating agent from the streaming run state (e.g., run_result.current_agent or updates from AgentUpdatedStreamEvent) instead of the initial agent.
Useful? React with 👍 / 👎.
|
@codex review again |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This pull request adds a new feature equivalent to openai/openai-agents-js#749