fix(docs): prevent mobile content overflow#25
Open
vyctorbrzezowski wants to merge 1 commit into
Open
Conversation
e4694d0 to
f975473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents docs content from widening the page on narrow mobile viewports.
Behavior notes
The fix is content-agnostic. The repro page used for verification is
/channels/discord/because it currently contains both a responsive table and long inline config keys, including:voice.realtime.providers.openai.interruptResponseOnInputAudio: falseAt 390px viewport width:
500px, creating horizontal page scroll.390px, and the long inline code wraps inside the viewport.Visual proof
Same route and 390px viewport, focused around the long inline config key.
Full evidence page: https://crisp-petal-g4gd.here.now/
Validation
git diff --checknode --check scripts/docs-site/assets.mjsnode --check scripts/docs-site/smoke.mjsnode --check scripts/docs-site/visual-smoke.mjsnpm run docs:build:previewnode --check dist/docs-site/assets/docs-site.js390, body width390, long inline code found and fitting