fix(docs): add expandable code block controls#28
Open
vyctorbrzezowski wants to merge 1 commit into
Open
Conversation
vyctorbrzezowski
force-pushed
the
brzezowski/docs-expandable-code-blocks
branch
from
bb158f8 to
94f12db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expandable code fences already had a capped height, but the rendered block did not explain that more content existed or give readers a way to reveal it. On long examples, that made the code feel abruptly clipped instead of intentionally collapsed.
This PR makes that state explicit:
Show more/Show lesscontrol forexpandablecode fencesScreenshots
Collapsed:
Expanded:
Testing
git diff --checkDOCS_SITE_PREVIEW_INCLUDE_FIXTURE=1 npm run docs:build:previewnode --check scripts/docs-site/assets.mjsnode --check scripts/docs-site/mdx-ish.mjsnode --check scripts/docs-site/elements-fixture.mjsnode --check scripts/docs-site/smoke.mjsnode --check dist/docs-site/assets/docs-site.js