Skip to content

Uk national #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
peterdudfield wants to merge 57 commits into
base: main
Choose a base branch
from
Open

Uk national #157

peterdudfield wants to merge 57 commits into from

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 17, 2025 •
edited
Loading

Pull Request

Description

Move uk-national over to this quartz-api

  • National routes
  • GSP routes
  • status routes - this loads from the old database for the moment. This will change in the future
  • system routes

Currently

  • forecast/all takes about ~13 seconds, which is to slow (benchmark from old app was). We currently looping over ForecastAtTimestamp
  • pvlive/all takes about ~10 seconds

#147

How Has This Been Tested?

  • CI tests
  • ran locally, and UAT from airflow run against the API
  • deployed and ran on aws, and UAT from airflow run against the API
  • TODO add end to end test for uk-national with the app

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
add framework for UK national and GSP
0aab57c
@peterdudfield
add gsp locations route
ac833c2
@peterdudfield
lint
f35f5b9
@peterdudfield
Merge branch 'main' into uk-national-and-gsp-framework
7a60342
@peterdudfield
Merge branch 'main' into uk-national-and-gsp-locations
5128fd3
@peterdudfield
PR comments
c382360
@peterdudfield
Update TODO elexon
caba26b
@peterdudfield
remove legacy routes
8d09c92
@peterdudfield
add start to getting national forecast
d16be98
@peterdudfield
Merge commit 'b1c66bee95de4ee6e27f7a4aa27865bd039d5523' into uk-natio…
c18b8be 
…nal-and-gsp-locations

# Conflicts:
#	src/quartz_api/cmd/main.py
#	src/quartz_api/internal/backends/dataplatform/client.py
#	src/quartz_api/internal/models.py
@peterdudfield
Merge commit 'b1c66bee95de4ee6e27f7a4aa27865bd039d5523' into uk-natio…
6203f51 
…nal-and-gsp-framework

# Conflicts:
#	src/quartz_api/cmd/main.py
@peterdudfield
rename + lint
3c7e911
@peterdudfield
Merge branch 'uk-national-and-gsp-framework' into uk-national-and-gsp…
459c24e 
…-locations

# Conflicts:
#	src/quartz_api/cmd/main.py
#	src/quartz_api/internal/service/uk_national/gsp.py
#	src/quartz_api/internal/service/uk_national/national.py
#	src/quartz_api/internal/service/uk_national/system.py
@peterdudfield
Merge branch 'uk-national-and-gsp-framework' into national/forecast
3110128 
# Conflicts:
#	src/quartz_api/internal/service/uk_national/national.py
@peterdudfield
get working for model_name
f01f99c
@peterdudfield
Merge commit 'ba856c2ed063512c437dbc9cd10472bf3d1ec146' into national…
618d0c7 
…/forecast
@peterdudfield
Merge branch 'main' into national/forecast
b9b3fb0 
# Conflicts:
#	src/quartz_api/internal/service/uk_national/national.py
@peterdudfield
Merge branch 'main' into uk-national-and-gsp-locations
702b73b 
# Conflicts:
#	src/quartz_api/internal/service/uk_national/gsp.py
#	src/quartz_api/internal/service/uk_national/national.py
#	src/quartz_api/internal/service/uk_national/system.py
@peterdudfield
lint
e3e068f
@peterdudfield
lint
0996fbf
@peterdudfield
national/pvlive
7ac4a80
@peterdudfield
lint
b038e79
@peterdudfield
Merge branch 'national/pvlive' into uk-national-and-gsp-locations
cce60d6 
# Conflicts:
#	src/quartz_api/internal/backends/dataplatform/client.py
@peterdudfield
tidy up
332f540
@peterdudfield
add options for get_window
2a8cb85
@peterdudfield
Merge branch 'start-end' into national/forecast
74ee1d6
@peterdudfield
add start and end datetime
91445bf
@peterdudfield
add start and end filters
539c4c8
@peterdudfield
lint
9297666
@peterdudfield
Merge branch 'start-end' into national/pvlive
0469b5b
peterdudfield and others added 19 commits December 12, 2025 10:55
@peterdudfield
Copy link
Contributor Author

peterdudfield commented Jan 5, 2026 •
edited
Loading

Worth mentioning some benchmarks for now, takes 22 seconds for pulling todays of all GSPs for 2 days of data.

The current API takes about ~3 seconds for 2 days of data

Note both these times have not caches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterdudfield @braddf