-
Notifications
You must be signed in to change notification settings - Fork 89
docs: add StreamedListObjects documentation #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add documentation for the StreamedListObjects API to the List Objects guide. Changes: - Add Streamed List Objects section explaining streaming differences - Include Node.js and Python SDK examples - Add note about SDK availability - Add related link to StreamedListObjects API reference Related: - openfga/js-sdk#280 - openfga/sdk-generator#654 - openfga/sdk-generator#76
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughDocumentation update for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/content/getting-started/perform-list-objects.mdx (1)
187-190: Add context or reference for theOPENFGA_LIST_OBJECTS_DEADLINEenvironment variable.The documentation mentions
OPENFGA_LIST_OBJECTS_DEADLINEas controlling the timeout limit, but does not explain its format, default value, or where to find configuration guidance. Consider adding a link to configuration documentation or brief inline explanation (e.g., unit of time, typical range) to help readers configure this appropriately.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/content/getting-started/perform-list-objects.mdx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: deploy-preview
- GitHub Check: Test deployment
- GitHub Check: Run Checks
- GitHub Check: markdown-link-check-md
🔇 Additional comments (2)
docs/content/getting-started/perform-list-objects.mdx (2)
240-244: StreamedListObjects API link verified and correctly formatted.The endpoint
/api/service#Relationship%20Queries/StreamedListObjectsis properly documented and actively referenced throughout the codebase (relationship-queries.mdx, tuples-api-best-practices.mdx). The link structure matches the established pattern used for other Relationship Queries endpoints (Check, ListObjects, ListUsers).
192-194: SDK availability note is accurate—both method names verified in official documentation.The Node.js SDK exposes the
streamedListObjectsmethod, and the Python SDK exposesstreamed_list_objects. The documented SDK availability statement correctly indicates that streaming functionality is available in Node.js and Python SDKs only, matching the actual SDK implementations.
- Add .NET SDK code sample in Streamed List Objects section - Update info notice to include .NET SDK support - Show IAsyncEnumerable pattern for streaming objects
- Create StreamedListObjectsRequestViewer component - Add .NET SDK code example for streaming objects - Update info notice to include .NET SDK support - Export new viewer component in index.ts
src/components/Docs/SnippetViewer/StreamedListObjectsRequestViewer.tsx
Outdated
Show resolved
Hide resolved
…ewer.tsx Co-authored-by: Raghd Hamzeh <[email protected]>
Summary
Adds StreamedListObjects documentation to the List Objects guide.
Changes
perform-list-objects.mdxRelated
Summary by CodeRabbit