8369506: Bytecode rewriting causes Java heap corruption on AArch64

[TheMangovnik]

Backport of JDK-8369506 - Bytecode rewriting causes Java heap corruption on AArch64.

Only manual change compared to the backport to JDK17 is in file src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp on line 1833. sizeof(markWord) had to be changed to sizeof(markOop), because markWord type is not present in JDK11. markOop should be JDK11 equivalent of markWord.

Tier 1 - PASSES

GTest - PASSES

GHA -PASSES

Only macos-x64 / test (hs/tier1 serviceability) fails, which seems to be common occurrence in other PRs too -> unrelated to this PR.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8369506 needs maintainer approval
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8369506: Bytecode rewriting causes Java heap corruption on AArch64 (Bug - P2 - Approved)

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3152/head:pull/3152
$ git checkout pull/3152

Update a local copy of the PR:
$ git checkout pull/3152
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3152

View PR using the GUI difftool:
$ git pr show -t 3152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3152.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheMangovnik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8369506: Bytecode rewriting causes Java heap corruption on AArch64

Reviewed-by: roland, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

• 18a3976: 8374888: Implement internal test cache to help UserIterCount test performance
• 7485d4c: 8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine
• 75bd1e4: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
• ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/86e9574c14850d08b016624c2217627eed826fdf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestrel, @theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (294d2723)

[jerboaa]

/reviewers 2

[jerboaa]

@adinn @rwestrel Could you please help review this? Thank you!

[openjdk]

@jerboaa
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheMangovnik]

/touch

[openjdk]

@TheMangovnik The pull request is being re-evaluated and the inactivity timeout has been reset.

[rwestrel]

Sorry, I missed this. Looks good to me.

[jerboaa]

@adinn Does it look OK to you too?

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheMangovnik]

/touch

[openjdk]

@TheMangovnik The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheMangovnik]

/template append

[TheMangovnik]

/touch

[openjdk]

@TheMangovnik The pull request template has been appended to the pull request body

[openjdk]

@TheMangovnik The pull request is being re-evaluated and the inactivity timeout has been reset.

[TheMangovnik]

/integrate

[openjdk]

@TheMangovnik
Your change (at version 294d272) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 96176ff.
Since your change was applied there have been 69 commits pushed to the master branch:

• 18a3976: 8374888: Implement internal test cache to help UserIterCount test performance
• 7485d4c: 8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine
• 75bd1e4: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
• ... and 66 more: https://git.openjdk.org/jdk11u-dev/compare/86e9574c14850d08b016624c2217627eed826fdf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @TheMangovnik Pushed as commit 96176ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.