New next app – Home Page, Datasets Header, and Slide-out Sidebar#361
New next app – Home Page, Datasets Header, and Slide-out Sidebar#361HelderMendes wants to merge 2 commits intoopenml:masterfrom
Conversation
|
I couldn't test the search functionality at the end of the day, because the remote server Elasticsearch was/is down for maintenance. |
joaquinvanschoren
left a comment
joaquinvanschoren
left a comment
There was a problem hiding this comment.
I sadly can't merge it like this. Please update or create a new PR with only the changes in /app-next
| - Better Google indexing and SEO ranking | ||
| - More intuitive, user-friendly URLs | ||
| - Improved sharing and citation experience | ||
| - Professional URL structure for academic referencesx |
| REACT_APP_URL_SITE_BACKEND=http://localhost:8000/ | ||
| REACT_APP_URL_API=http://localhost:8000/api/ | ||
| REACT_APP_URL_ELASTICSEARCH=http://localhost:8000/es/ | ||
| REACT_APP_URL_API=https://www.openml.org/api/ |
There was a problem hiding this comment.
Don't edit .env - we don't want to overwrite variables on the server. You can use .env.dev or create a new file.
There was a problem hiding this comment.
Understood! I'll use the existing .env.dev for local development going forward. The new PR won't include any
.env changes - it will remain as the production configuration.
There was a problem hiding this comment.
Don't add readmes for a PR. Just add this information in the PR description on GitHub
There was a problem hiding this comment.
Do you want to push changes to app/src ? These only seem whitespace updates.
There was a problem hiding this comment.
Thanks for the guidance! I'll make sure to use the GitHub PR description for this information in all future PRs
There was a problem hiding this comment.
Did you mean to update this? why?
There was a problem hiding this comment.
No, that was a mistake - I did a project-wide search/replace that accidentally modified files outside /app-next. Tried to revert but missed some.
The new PR will be clean: only /app-next changes, no .md files, no editor auto-formatting noise, as I learned from you.
|
Closing since covered in other PRs |
2 participants
Summary
This PR introduces UI improvements and new components for the OpenML Next.js application, focusing on the home page hero section, dataset detail pages, and navigation enhancements.
Changes
🏠 Home Page
📊 Dataset Pages
dataset-header.tsx): Clean, informative header displaying:dataset-metadata-grid.tsx): Organized display of dataset propertiesfeature-table.tsx): Sortable table for dataset featuresquality-table.tsx): Display of dataset quality metricsdataset-description.tsx): Formatted description with markdown supportdataset-action-bar.tsx): Quick actions for dataset operations🧭 Navigation (1)
sidebar.tsx): Responsive navigation sidebar with:obs:
🔍 Search Improvements
search-container.tsx: Main search wrapperfilter-bar.tsx: Advanced filtering optionscontrols-bar.tsx: Search controlsresults-table.tsx: Improved results displaysearch-config.ts: Centralized search configurationOpenMLSearchConnector.ts)🎨 UI Components
Added shadcn/ui components for consistent design:
🔧 Technical Improvements
Testing
Note: This PR maintains backward compatibility with legacy URLs through the proxy configuration.
Question: (Example: page with datasets) is 100% wide, or is it 100% wide minus the sidebar, but animates to fill the space if the sidebar slide out.