Repository navigation
bugfix: clean pending operations in ordinary coroutines. - #2545
Merged
Merged
Conversation
Cancel pending timers and cosocket operations before freeing request-owned coroutine contexts, including coroutines without Lua registry references. Previously, aborting a request with a nested ngx.sleep could leave its timer in the Nginx tree and trigger a heap use-after-free. Add client-abort and ngx.exit regression coverage for pending sleeps in ordinary coroutines, including nesting across coroutine-context list parts. Validated with the new test against a pre-fix ASan binary (both scenarios report UAF), then against the fixed build. t/077-sleep.t, t/091-coroutine.t, and t/197-coroutine-request-cleanup.t pass 460 assertions; client-abort suites pass 364 more. No ASan reports remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel pending timers and cosocket operations before freeing request-owned coroutine contexts, including coroutines without Lua registry references. Previously, aborting a request with a nested ngx.sleep could leave its timer in the Nginx tree and trigger a heap use-after-free.
Add client-abort and ngx.exit regression coverage for pending sleeps in ordinary coroutines, including nesting across coroutine-context list parts.
Validated with the new test against a pre-fix ASan binary (both scenarios report UAF), then against the fixed build. t/077-sleep.t, t/091-coroutine.t, and t/197-coroutine-request-cleanup.t pass 460 assertions; client-abort suites pass 364 more. No ASan reports remain.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.