Repository navigation
Preserve the first zone checkbox toggle - #696
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first click or Space activation on an unselected zone checkbox could be lost when the parent card selected the zone before the native change event recorded its value.
Record the checkbox value before selecting the card. Keep the existing label, focus behavior, and save payload.
main, two first-activation cases fail and four controls pass. With the fix, all six pass; the 16 geometry tests and all 569 web unit tests also pass. Production build passes.npm --prefix web run test:e2e -- --testPathPatterns=zoneEditorCheckbox(root/web dependencies and Playwright Chromium required).Extracted independently from #693; no foundation tooling or accessibility redesign is included.