AGENT-1309: Modify NoRegistryClusterInstall storage requirements #1836
Conversation
pawanpinjarkar
force-pushed
the
modify-hw-storage-requirements-for-NRCI
branch
from
df5358b to
2e5d438
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/uncc @sadasu @cybertron |
openshift-ci
bot
requested review from
andfasano and
rwsu
and removed request for
cybertron and
sadasu
common.sh
Outdated
| # Increase disk storage requirements for NoRegistryClusterInstall aka agent OVE ISO | ||
| export MASTER_DISK=220 | ||
| export WORKER_DISK=220 | ||
| export ARBITER_DISK=220 |
There was a problem hiding this comment.
Until the TNF will be explicitly supported (and currently it is not), I'd prefer to not have any explicit configuration setting for it
pawanpinjarkar
force-pushed
the
modify-hw-storage-requirements-for-NRCI
branch
from
2e5d438 to
d363974
Compare
common.sh
Outdated
| case "$SCENARIO" in | ||
| "SNO"|"COMPACT"|"HA" ) | ||
| export MASTER_DISK=220 | ||
| export WORKER_DISK=220 |
There was a problem hiding this comment.
| export WORKER_DISK=220 |
The requirement is only for master nodes, not for the workers
There was a problem hiding this comment.
@pawanpinjarkar I just noticed that openshift/installer#10176 force 220Gb also for the workers, so please fix it as well. To avoid keep blocking the CI, let's land this PR as it is and then please fix both installer/dev-scripts repos for the worker
There was a problem hiding this comment.
openshift/installer#10254 fixes the installer
|
/lgtm |
|
/override ci/prow/e2e-metal-ipi-bm This patch does not seem related |
|
@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-metal-ipi-bm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
1 similar comment
|
/test e2e-agent-compact-ipv4-iso-no-registry |
|
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
|
@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-metal-ipi-ovn-ipv6 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pawanpinjarkar
force-pushed
the
modify-hw-storage-requirements-for-NRCI
branch
2 times, most recently
from
d363974 to
7e6f735
Compare
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-merge-bot
bot
merged commit bed38e9
into
openshift-metal3:master
3 participants
Modify NoRegistryClusterInstall storage requirements