OCPBUGS-67232: Move DynamicConfigurationManager back to TPNU

[Miciah]

Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"

This reverts #2552.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-67232, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Revert "OCPBUGS-62987: Move DynamicConfigurationManager back to DevPreview"

This reverts #2552.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

IngressControllerDynamicConfigurationManager is enabled for TechPreviewNoUpgrade in addition to DevPreviewNoUpgrade; documentation and the feature declaration were updated, and the feature was moved from disabled to enabled in the Hypershift and SelfManagedHA TechPreviewNoUpgrade FeatureGate manifests.

Changes

Cohort / File(s)	Summary
Feature docs features.md	Repositioned IngressControllerDynamicConfigurationManager entry and mark it as Enabled across Hypershift and SelfManagedHA for both DevPreviewNoUpgrade and TechPreviewNoUpgrade.
Feature declaration (Go) features/features.go	Updated initialization metadata for FeatureGateIngressControllerDynamicConfigurationManager: set enhancementPR to "https://github.com/openshift/enhancements/pull/1687" and extended enableIn to include configv1.TechPreviewNoUpgrade alongside configv1.DevPreviewNoUpgrade.
TechPreviewNoUpgrade FeatureGate manifests payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml, payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml	Moved IngressControllerDynamicConfigurationManager from the FeatureGate status.disabled list to status.enabled for TechPreviewNoUpgrade.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify the enhancementPR URL (https://github.com/openshift/enhancements/pull/1687) is the intended reference.
• Confirm enableIn change matches the rollout decision (DevPreviewNoUpgrade + TechPreviewNoUpgrade).
• Check features.md table formatting and that the feature is Enabled in all four displayed deployment-mode cells.
• Validate YAML edits changed only the intended feature entry and preserved manifest structure.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 053d7dc and 845ec5e.

📒 Files selected for processing (1)

• features/features.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• features/features.go

🧬 Code graph analysis (1)

features/features.go (1)

config/v1/types_feature.go (2)

• DevPreviewNoUpgrade (49-49)
• TechPreviewNoUpgrade (45-45)

🔇 Additional comments (1)

features/features.go (1)

633-634: IngressControllerDynamicConfigurationManager gating and EP link look correct

enhancementPR now points at the concrete EP PR and enableIn includes both DevPreviewNoUpgrade and TechPreviewNoUpgrade, which matches the stated intent of moving this feature back into TPNU. No functional or maintainability issues from this change.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Miciah]

Cc'ing author and reviewers from the reverted PR:
/cc @candita
/cc @alebedev87
/cc @JoelSpeed

[JoelSpeed]

/lgtm

BTW, this has no EP linked, is there any EP?

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[Miciah]

BTW, this has no EP linked, is there any EP?

Yes: https://github.com/openshift/enhancements/blob/master/enhancements/ingress/dynamic-config-manager.md

Should I update the PR with a reference?

[Miciah]

Well, features/features.go links to PRs; openshift/enhancements#1687 is the PR for the EP.

[JoelSpeed]

Can you update l633 to remove the legacy feature gate thing and add the actual Ep link in?

[Miciah]

ci/prow/verify failed:

panic: FeatureGate/IngressControllerDynamicConfigurationManager enhancementPR format is incorrect; must be like https://github.com/openshift/enhancements/pull/#### or https://github.com/kubernetes/enhancements/issues/#### 

https://github.com/openshift/api/compare/053d7dc9eb425a835f21f151558ea7f2eb26b064..845ec5ef5e49ef176ee0567fa3d6c5f3d35ecb38 updates the link to point to the PR instead.

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Miciah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview-1of2	845ec5e	link	true	/test e2e-aws-serial-techpreview-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.