CORS-4550: Promote GCD to Default

[patrickdillon]

Move GCD to default featureset. Promoted via SBAR.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@patrickdillon: This pull request references CORS-4550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Move GCD to default featureset. Promoted via SBAR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c3e1974c-a3b9-4a5e-8d62-0d0ae730f061

📥 Commits

Reviewing files that changed from the base of the PR and between 4912562 and 370198a.

⛔ Files ignored due to path filters (4)

• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (8)

• features.md
• features/features.go
• payload-manifests/crds/0000_10_config-operator_01_infrastructures-Default.crd.yaml
• payload-manifests/crds/0000_10_config-operator_01_infrastructures-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-OKD.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change enables GCPSovereignCloudInstall in default and OKD feature sets and supported 4.10 manifests. It moves OSStreams to the disabled list in the Hypershift Default manifest. It adds the optional GCP universeDomain field to Infrastructure and ControllerConfig CRD schemas with DNS subdomain validation.

Possibly related PRs

• openshift/api#2993: Modifies feature-gate promotion and Hypershift Default/OKD manifests for OSStreams.

Suggested reviewers: everettraven, vr4manta, sadasu

Merge Risk: 🔵 Low · up to 37019

Promoting GCD to default updates CRD schemas with validation that depends on the apiserver CEL format library; unsupported Kubernetes versions could experience CRD installation or validation failures. The change is mergeable with explicit owner confirmation that all supported target versions provide this function.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the issue and the primary change: promoting GCD to the default featureset.
Description check	✅ Passed	The description directly matches the changeset by stating that GCD moves to the default featureset and linking the SBAR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR diff changes feature metadata, CRD schemas, and feature-gate manifests only; it adds no test-like files or Ginkgo test declarations.
Test Structure And Quality	✅ Passed	The commit changes only CRD, feature-gate, and documentation files; it adds no Ginkgo tests or test-related code, so these requirements are inapplicable.
Microshift Test Compatibility	✅ Passed	The pull request changes only feature-gate and CRD manifests; it adds no Ginkgo tests or test references that could violate MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests; its changed files are feature-gate metadata and generated CRD manifests, so the SNO test-compatibility check is not triggered.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes feature-gate enablement and CRD schema fields only; added-line scans found no affinity, spread, replica, selector, toleration, or PDB scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes feature metadata and CRD YAML plus one declarative feature-gate option; the diff adds no OTE process entrypoint, logging, or stdout write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes feature metadata, feature-gate manifests, and generated CRDs only; it adds no Go files or Ginkgo e2e tests requiring IPv4 or external connectivity.
No-Weak-Crypto	✅ Passed	The master-to-HEAD diff changes feature-gate metadata and CRD/YAML DNS validation only; added lines contain no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto, or secret comparisons.
Container-Privileges	✅ Passed	The diff changes CRD schemas, feature-gate lists, and documentation only; no introduced privileged, host*, SYS_ADMIN, allowPrivilegeEscalation, or container security settings were found.
No-Sensitive-Data-In-Logs	✅ Passed	The commit changes CRD schemas, feature-gate manifests, and a feature matrix only; added lines contain no logging calls or sensitive data values.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[JoelSpeed]

Also needs

Suggested change

	enable(inDefault(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
	enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).

[JoelSpeed]

Could you please link the SBAR and the installer side promotion PR please?

[patrickdillon]

Could you please link the SBAR

Yes, I wasn't sure if we wanted to link out to a doc like that in GH. Here's the SBAR.

and the installer side promotion PR please?

An installer PR depends on this merging, so I haven't created yet. I can create one using my local branch if that helps.

[patrickdillon]

I meant to say, I will create the installer pr pointing to my local branch

[patrickdillon]

Installer PR: openshift/installer#10775

[JoelSpeed]

Based on https://sippy.dptools.openshift.org/sippy-ng/feature_gates/5.1/GCPSovereignCloudInstall I can now see we have some dedicated testing in place, and while run counts are low, it appears to be working and passing.

/override verify-feature-promotion

We have an approved SBAR for this feature, so will move forward without the "sufficient" CI

/lgtm

[openshift-ci]

@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• verify-feature-promotion

Only the following failed contexts/checkruns were expected:

• CodeRabbit
• ci/prow/build
• ci/prow/e2e-aws-ovn
• ci/prow/e2e-aws-ovn-hypershift
• ci/prow/e2e-aws-ovn-hypershift-conformance
• ci/prow/e2e-aws-ovn-techpreview
• ci/prow/e2e-aws-serial-1of2
• ci/prow/e2e-aws-serial-2of2
• ci/prow/e2e-aws-serial-techpreview-1of2
• ci/prow/e2e-aws-serial-techpreview-2of2
• ci/prow/e2e-azure
• ci/prow/e2e-gcp
• ci/prow/e2e-upgrade
• ci/prow/e2e-upgrade-out-of-change
• ci/prow/e2e-vsphere-ovn
• ci/prow/images
• ci/prow/integration
• ci/prow/lint
• ci/prow/minor-e2e-upgrade-minor
• ci/prow/minor-images
• ci/prow/okd-scos-images
• ci/prow/unit
• ci/prow/verify
• ci/prow/verify-client-go
• ci/prow/verify-crd-schema
• ci/prow/verify-crdify
• ci/prow/verify-deps
• ci/prow/verify-feature-promotion
• ci/prow/verify-hypershift-integration
• pull-ci-openshift-api-master-build
• pull-ci-openshift-api-master-e2e-aws-ovn
• pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
• pull-ci-openshift-api-master-e2e-aws-ovn-hypershift-conformance
• pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
• pull-ci-openshift-api-master-e2e-aws-serial-1of2
• pull-ci-openshift-api-master-e2e-aws-serial-2of2
• pull-ci-openshift-api-master-e2e-aws-serial-techpreview-1of2
• pull-ci-openshift-api-master-e2e-aws-serial-techpreview-2of2
• pull-ci-openshift-api-master-e2e-azure
• pull-ci-openshift-api-master-e2e-gcp
• pull-ci-openshift-api-master-e2e-upgrade
• pull-ci-openshift-api-master-e2e-upgrade-out-of-change
• pull-ci-openshift-api-master-e2e-vsphere-ovn
• pull-ci-openshift-api-master-images
• pull-ci-openshift-api-master-integration
• pull-ci-openshift-api-master-lint
• pull-ci-openshift-api-master-minor-e2e-upgrade-minor
• pull-ci-openshift-api-master-minor-images
• pull-ci-openshift-api-master-okd-scos-images
• pull-ci-openshift-api-master-unit
• pull-ci-openshift-api-master-verify
• pull-ci-openshift-api-master-verify-client-go
• pull-ci-openshift-api-master-verify-crd-schema
• pull-ci-openshift-api-master-verify-crdify
• pull-ci-openshift-api-master-verify-deps
• pull-ci-openshift-api-master-verify-feature-promotion
• pull-ci-openshift-api-master-verify-hypershift-integration
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

Based on https://sippy.dptools.openshift.org/sippy-ng/feature_gates/5.1/GCPSovereignCloudInstall I can now see we have some dedicated testing in place, and while run counts are low, it appears to be working and passing.

/override verify-feature-promotion

We have an approved SBAR for this feature, so will move forward without the "sufficient" CI

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/override ci/prow/verify-feature-promotion

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

Details

In response to this:

/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance	370198a	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-serial-techpreview-2of2	370198a	link	true	/test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-2of2	370198a	link	true	/test e2e-aws-serial-2of2
ci/prow/minor-e2e-upgrade-minor	370198a	link	true	/test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.