[QiWang19]

Following up on comment: #2844 (review)
Re-applied commit ba4a042 to drop the v1alpha1 Go type definitions now that 5.1 has branched. Note that the OpenAPI schema was already dropped in a previous PR.

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

[openshift-ci]

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 7168474c-5311-422c-86d6-31529ea37535

📥 Commits

Reviewing files that changed from the base of the PR and between 24b2699 and 50d6a72.

⛔ Files ignored due to path filters: 9

• config/v1alpha1/zz_generated.crd-manifests/0000_10_config-operator_01_criocredentialproviderconfigs-Hypershift.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1alpha1/zz_generated.crd-manifests/0000_10_config-operator_01_criocredentialproviderconfigs-SelfManagedHA.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1alpha1/zz_generated.deepcopy.go is excluded by !**/zz_generated*
• config/v1alpha1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/zz_generated*
• config/v1alpha1/zz_generated.featuregated-crd-manifests/criocredentialproviderconfigs.config.openshift.io/CRIOCredentialProviderConfig.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1alpha1/zz_generated.model_name.go is excluded by !**/zz_generated*
• config/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !**/zz_generated*
• openapi/generated_openapi/zz_generated.openapi.go is excluded by !openapi/**, !**/zz_generated*
• openapi/openapi.json is excluded by !openapi/**

📒 Files selected for processing: 3

• config/v1alpha1/register.go
• config/v1alpha1/tests/criocredentialproviderconfigs.config.openshift.io/CRIOCredentialProviderConfig.yaml
• config/v1alpha1/types_crio_credential_provider_config.go

💤 Files with no reviewable changes: 3

• config/v1alpha1/tests/criocredentialproviderconfigs.config.openshift.io/CRIOCredentialProviderConfig.yaml
• config/v1alpha1/register.go
• config/v1alpha1/types_crio_credential_provider_config.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The v1alpha1 CRI-O credential-provider API types and related constants were deleted. The scheme no longer registers the resource or list. The associated validation test file was also deleted.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 50d6a

The v1alpha1 API removal appears complete, while the v1 resource remains available. No actionable merge risk was identified.

Pre-merge checks: 15

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names		PASS: The pull request adds no test titles. The only test-file change deletes the CRIOCredentialProviderConfig validation tests, whose removed names were static and contained no dynamic values or lega…
Test Structure And Quality		PASS. The pull request adds no Ginkgo tests. It deletes the existing CRIOCredentialProviderConfig validation test and removes the API types and registrations. Therefore, the listed test-structure requ…
Microshift Test Compatibility		The pull request adds no Ginkgo e2e tests. The authoritative diff only removes the v1alpha1 CRI-O configuration API and its validation test, plus updates generated files. The MicroShift compatibility …
Single Node Openshift (Sno) Test Compatibility		The pull request adds no Ginkgo e2e tests. The authoritative diff contains only deletions and generated-file updates, with no added It(), Describe(), Context(), or When() declarations. The SNO compati…
Topology-Aware Scheduling Compatibility		PASS: The pull request only removes the v1alpha1 CRIOCredentialProviderConfig API, its tests, CRDs, and generated registration/OpenAPI/deep-copy metadata. The diff adds or changes no deployment manife…
Ote Binary Stdout Contract		The reviewed range contains only deletions: 1,385 lines removed and no additions. Changes remove the v1alpha1 CRI-O API, generated artifacts, tests, and scheme registrations. No changed file contains …
Ipv6 And Disconnected Network Test Compatibility		The pull request adds no new Ginkgo e2e tests. The only test-related change deletes a v1alpha1 YAML validation test file, and the remaining changes remove API types, generated manifests, and scheme re…
No-Weak-Crypto		The PR contains only deletions: 1,385 lines removed and no added lines. The changes remove the CRIOCredentialProviderConfig API, generated artifacts, tests, and scheme registrations. No MD5, SHA1, DES…
Container-Privileges		PASS: The pull request introduces no container-privilege settings. The authoritative diff contains 0 additions and 1,385 deletions only. It removes the v1alpha1 CRIOCredentialProviderConfig types, reg…
No-Sensitive-Data-In-Logs		The pull request introduces no logging statements or log message content. The authoritative diff contains 0 additions and only removes the CRIOCredentialProviderConfig API, registrations, generated me…
Title check		The title clearly identifies the primary change: removing the v1alpha1 CRIOCredentialProviderConfig API. It contains a typo in "v1apha1," but the intended API version remains clear.
Description check		The description explains that the v1alpha1 Go type definitions are being removed and provides relevant background for the change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request adds no test titles. The only test-file change deletes the CRIOCredentialProviderConfig validation tests, whose removed names were static and contained no dynamic values or legacy metadata tokens. The remaining changes remove API and generated definitions.

Full details: Test Structure And Quality

Explanation

PASS. The pull request adds no Ginkgo tests. It deletes the existing CRIOCredentialProviderConfig validation test and removes the API types and registrations. Therefore, the listed test-structure requirements do not identify a new test issue.

Full details: Microshift Test Compatibility

Explanation

The pull request adds no Ginkgo e2e tests. The authoritative diff only removes the v1alpha1 CRI-O configuration API and its validation test, plus updates generated files. The MicroShift compatibility check is therefore not triggered.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The pull request adds no Ginkgo e2e tests. The authoritative diff contains only deletions and generated-file updates, with no added It(), Describe(), Context(), or When() declarations. The SNO compatibility check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request only removes the v1alpha1 CRIOCredentialProviderConfig API, its tests, CRDs, and generated registration/OpenAPI/deep-copy metadata. The diff adds or changes no deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is not applicable.

Full details: Ote Binary Stdout Contract

Explanation

The reviewed range contains only deletions: 1,385 lines removed and no additions. Changes remove the v1alpha1 CRI-O API, generated artifacts, tests, and scheme registrations. No changed file contains process-level OTE code or stdout writes such as fmt.Print, log.Print, klog output, or Ginkgo suite setup.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

The pull request adds no new Ginkgo e2e tests. The only test-related change deletes a v1alpha1 YAML validation test file, and the remaining changes remove API types, generated manifests, and scheme registrations. Therefore, the IPv4 and external-connectivity conditions do not apply.

Full details: No-Weak-Crypto

Explanation

The PR contains only deletions: 1,385 lines removed and no added lines. The changes remove the CRIOCredentialProviderConfig API, generated artifacts, tests, and scheme registrations. No MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code is introduced.

Full details: Container-Privileges

Explanation

PASS: The pull request introduces no container-privilege settings. The authoritative diff contains 0 additions and 1,385 deletions only. It removes the v1alpha1 CRIOCredentialProviderConfig types, registration, tests, generated CRDs, and OpenAPI entries. No added line contains privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation: true.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request introduces no logging statements or log message content. The authoritative diff contains 0 additions and only removes the CRIOCredentialProviderConfig API, registrations, generated metadata, and tests. Therefore, it does not introduce sensitive data exposure in logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

[redhat-chai-bot]

Chai test selection for 50d6a720146827c47798558e696cf55d18fef2b5 → master

None.

Reason: No e2e tests needed. This PR is a pure deletion (0 additions, 1,175 deletions across 12 files) removing the entire CRIOCredentialProviderConfig v1alpha1 API type, which was gated behind the CRIOCredentialProviderConfig feature gate (not enabled in Default profile). Changed surfaces: None that affect runtime behavior. All changes are to Go source types (config/v1alpha1/types_crio_credential_provider_config.go, register.go), generated code (zz_generated.deepcopy.go, zz_generated.openapi.go, swagger docs, model names, OpenAPI JSON), CRD manifests in zz_generated.crd-manifests/ (not payload-manifests/), and test fixtures. No payload-manifests/, manifests/, payload-command/, Dockerfile.ocp, or Makefile files are modified — the payload image content is identical before and after this change. Coverage: First-stage build/verify/unit jobs validate compilation consistency and would catch any breakage from the type deletion. No candidate exercises CRIOCredentialProviderConfig — the feature gate was never enabled in Default or TechPreviewNoUpgrade test profiles exercised by these candidates. The removed CRD topology variants (Hypershift CustomNoUpgrade, SelfManagedHA) are not installed or tested by any candidate job in their default configurations.

[redhat-chai-bot]

/pipeline mark-pipeline-gate 50d6a72

[QiWang19]

/verified by @QiWang19

[openshift-ci-robot]

@QiWang19: This PR has been marked as verified by @QiWang19.

Details

In response to this:

/verified by @QiWang19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@QiWang19: This pull request references OCPNODE-4827 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Following up on comment: #2844 (review) Following up on:
Re-applied commit ba4a042 to drop the v1alpha1 Go type definitions now that 5.1 has branched. Note that the OpenAPI schema was already dropped in a previous PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.