-
Notifications
You must be signed in to change notification settings - Fork 281
NVIDIA-554: DPU-host mode: use ConfigMap for OVN feature enablement instead of per-node script gating #2907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,14 +33,23 @@ data: | |
| dns-service-name="dns-default" | ||
|
|
||
| [ovnkubernetesfeature] | ||
| enable-egress-ip=true | ||
| enable-egress-firewall=true | ||
| enable-egress-qos=true | ||
| enable-egress-service=true | ||
| {{- if .ReachabilityNodePort }} | ||
| egressip-node-healthcheck-port={{.ReachabilityNodePort}} | ||
| {{- end }} | ||
| {{- if not .OVN_MULTI_NETWORK_ENABLE }} | ||
| enable-multi-network=true | ||
| {{- end }} | ||
| enable-network-segmentation=true | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is redundant (in managed and self-hosted), since we're already setting
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure, this is the configmap, i believe enable it here, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops, yes. Not sure what I was up to here. :-D |
||
| enable-preconfigured-udn-addresses=true | ||
|
|
||
| {{- if .OVN_MULTI_NETWORK_POLICY_ENABLE }} | ||
| enable-multi-networkpolicy=true | ||
| {{- end }} | ||
| enable-admin-network-policy=true | ||
| enable-multi-external-gateway=true | ||
|
tsorya marked this conversation as resolved.
|
||
| enable-multicast=true | ||
| {{- if .DNS_NAME_RESOLVER_ENABLE }} | ||
| enable-dns-name-resolver=true | ||
| {{- end }} | ||
|
|
@@ -117,14 +126,15 @@ data: | |
| {{- if .ReachabilityNodePort }} | ||
| egressip-node-healthcheck-port={{.ReachabilityNodePort}} | ||
| {{- end }} | ||
| {{- if .OVN_MULTI_NETWORK_ENABLE }} | ||
| enable-multi-network=true | ||
| {{- end }} | ||
| {{- if not .OVN_MULTI_NETWORK_ENABLE }} | ||
| enable-multi-network=true | ||
| {{- end }} | ||
| enable-network-segmentation=true | ||
| enable-preconfigured-udn-addresses=true | ||
| {{- if .OVN_MULTI_NETWORK_POLICY_ENABLE }} | ||
| enable-multi-networkpolicy=true | ||
| {{- end }} | ||
| enable-admin-network-policy=true | ||
| enable-multi-external-gateway=true | ||
| enable-multicast=true | ||
| {{- if .DNS_NAME_RESOLVER_ENABLE }} | ||
| enable-dns-name-resolver=true | ||
| {{- end }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,19 +129,8 @@ spec: | |
| ovn_v6_masquerade_subnet_opt="--gateway-v6-masquerade-subnet {{.V6MasqueradeSubnet}}" | ||
| fi | ||
|
|
||
| dns_name_resolver_enabled_flag= | ||
| if [[ "{{.DNS_NAME_RESOLVER_ENABLE}}" == "true" ]]; then | ||
| dns_name_resolver_enabled_flag="--enable-dns-name-resolver" | ||
| fi | ||
|
|
||
| persistent_ips_enabled_flag="--enable-persistent-ips" | ||
|
|
||
| # This is needed so that converting clusters from GA to TP | ||
| # will rollout control plane pods as well | ||
| network_segmentation_enabled_flag= | ||
| multi_network_enabled_flag="--enable-multi-network" | ||
| network_segmentation_enabled_flag="--enable-network-segmentation" | ||
|
|
||
| route_advertisements_enable_flag= | ||
| if [[ "{{.OVN_ROUTE_ADVERTISEMENTS_ENABLE}}" == "true" ]]; then | ||
| route_advertisements_enable_flag="--enable-route-advertisements" | ||
|
|
@@ -151,18 +140,7 @@ spec: | |
| if [[ "{{.OVN_EVPN_ENABLE}}" == "true" ]]; then | ||
| evpn_enable_flag="--enable-evpn" | ||
| fi | ||
|
|
||
| preconfigured_udn_addresses_enable_flag="--enable-preconfigured-udn-addresses" | ||
|
|
||
| # Enable multi-network policy if configured (control-plane always full mode) | ||
| multi_network_policy_enabled_flag= | ||
| if [[ "{{.OVN_MULTI_NETWORK_POLICY_ENABLE}}" == "true" ]]; then | ||
| multi_network_policy_enabled_flag="--enable-multi-networkpolicy" | ||
| fi | ||
|
|
||
| # Enable admin network policy if configured (control-plane always full mode) | ||
| admin_network_policy_enabled_flag="--enable-admin-network-policy" | ||
|
|
||
| if [ "{{.OVN_GATEWAY_MODE}}" == "shared" ]; then | ||
| gateway_mode_flags="--gateway-mode shared" | ||
| elif [ "{{.OVN_GATEWAY_MODE}}" == "local" ]; then | ||
|
|
@@ -187,22 +165,10 @@ spec: | |
| ${ovn_v6_transit_switch_subnet_opt} \ | ||
| ${ovn_v4_masquerade_subnet_opt} \ | ||
| ${ovn_v6_masquerade_subnet_opt} \ | ||
| ${dns_name_resolver_enabled_flag} \ | ||
| ${persistent_ips_enabled_flag} \ | ||
| ${multi_network_enabled_flag} \ | ||
| ${network_segmentation_enabled_flag} \ | ||
| ${gateway_mode_flags} \ | ||
| ${route_advertisements_enable_flag} \ | ||
| ${evpn_enable_flag} \ | ||
| ${preconfigured_udn_addresses_enable_flag} \ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is part of configmap https://github.com/openshift/cluster-network-operator/blob/master/bindata/network/ovn-kubernetes/managed/004-config.yaml#L43 no point to have it in both place as especially if configmap |
||
| --enable-egress-ip=true \ | ||
| --enable-egress-firewall=true \ | ||
| --enable-egress-qos=true \ | ||
| --enable-egress-service=true \ | ||
| --enable-multicast \ | ||
| --enable-multi-external-gateway=true \ | ||
| ${multi_network_policy_enabled_flag} \ | ||
| ${admin_network_policy_enabled_flag} | ||
| ${evpn_enable_flag} | ||
| volumeMounts: | ||
| - mountPath: /run/ovnkube-config/ | ||
| name: ovnkube-config | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.