no-jira: Update OWNERS_ALIASES to include myself + "taanyas" and "marty-power"#2908
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| core-reviewers: | ||
| - arghosh93 | ||
| - arkadeepsen | ||
| - arkadeepsen |
There was a problem hiding this comment.
was there a trailing whitespace? here and for peri? seems unrelated change hence asking
There was a problem hiding this comment.
yes, I removed them (actually AI did once I asked to order alphabetically :D )
|
/lgtm |
|
/hold I'd wait till Tanya becomes an org member, else its technically incorrect to add her github user handle from security perspective |
|
/verify-owners |
|
/remove-hold |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
… as reviewers, clean up formatting, and remove "ricky-rav" as he left Red Hat. Signed-off-by: Matteo Dallaglio <mdallagl@redhat.com>
248f366 to
d8c7bbf
Compare
|
/lgtm |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattedallo, pliurh, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by CI |
|
@pliurh: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle no-jira: Update OWNERS_ALIASES to include myself + "taanyas" and "marty-power" |
|
@mattedallo: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
f5e61cd
into
openshift:master
|
@mattedallo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thanks @pliurh |
Update OWNERS_ALIASES to include myself ("mattedallo") + "taanyas" and "marty-power" as reviewers.
Remove "ricky-rav" as he left Red Hat.
Removed some trailing spaces.