NO-ISSUE: automate OCP-46422 and adding in-cluster Cincinnati by JianLi-RH · Pull Request #1354 · openshift/cluster-version-operator

JianLi-RH · 2026-03-19T07:24:12Z

As we discussed in https://redhat-internal.slack.com/archives/CJ1J9C3V4/p1773852594419879?thread_ts=1773825774.280769&cid=CJ1J9C3V4

we can generate Cincinnati json and inject it to a test pod, then we use the pod's service URI for upstream.

This PR implements some common methods and finished test case: https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-46422

coderabbitai · 2026-03-19T07:24:23Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e795188c-e426-423b-a110-42fb2a4b8da4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-19T07:25:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JianLi-RH
Once this PR has been reviewed and has the lgtm label, please assign hongkailiu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JianLi-RH · 2026-03-27T06:42:40Z

Test passed on my local machine:
The test cluster:

launch 4.22.0-ec.4 aws

Cluster-bot log: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/2037388148400459776

[jianl@jianl-thinkpadt14gen4 cluster-version-operator]$ _output/linux/amd64/cluster-version-operator-tests run-test "[Jira:\"Cluster Version Operator\"] cluster-version-operator cvo drops invalid conditional edges"
  Running Suite:  - /home/jianl/1_code/cluster-version-operator
  =============================================================
  Random Seed: 1774595641 - will randomize all specs

  Will run 1 of 1 specs
  ------------------------------
  [Jira:"Cluster Version Operator"] cluster-version-operator cvo drops invalid conditional edges [Lifecycle:informing, 46422, Low, ConnectedOnly, Serial]
  /home/jianl/1_code/cluster-version-operator/test/cvo/cvo.go:114
  "level"=0 "msg"="microshift-version configmap not found"
    STEP: create upstream graph template with invalid conditional edges @ 03/27/26 15:14:05.139
    STEP: run update service with the graph template @ 03/27/26 15:14:05.139
  cluster-version-operator-tests "level"=0 "msg"="deployment1: image-registry.openshift-image-registry.svc:5000/openshift/tools:latest, update-service, 8000"
  cluster-version-operator-tests "level"=0 "msg"="Update Service URL: http://172.30.116.102:46422/graph"
  cluster-version-operator-tests "level"=0 "msg"="Service: update-service, 824634142504, {0 8000 }"
    STEP: patch upstream with null target node conditional edge @ 03/27/26 15:14:09.946
I0327 15:14:10.739074  283667 warnings.go:107] "Warning: unknown field \"spec.signatureStores\""
I0327 15:14:11.941931  283667 warnings.go:107] "Warning: unknown field \"spec.signatureStores\""
    STEP: prepare new graph file @ 03/27/26 15:14:12.386
    STEP: create upstream graph template with multi risks conditional edges @ 03/27/26 15:14:12.387
    STEP: run update service with the multi risks graph template @ 03/27/26 15:14:12.387
  cluster-version-operator-tests "level"=0 "msg"="Update Service URL: http://172.30.169.151:46422/graph"
  cluster-version-operator-tests "level"=0 "msg"="Service: update-service, 824637682888, {0 8000 }"
    STEP: patch upstream with multi risks conditional edge @ 03/27/26 15:14:17.131
I0327 15:14:17.927412  283667 warnings.go:107] "Warning: unknown field \"spec.signatureStores\""
I0327 15:16:29.004058  283667 warnings.go:107] "Warning: unknown field \"spec.signatureStores\""
I0327 15:16:30.736091  283667 warnings.go:107] "Warning: unknown field \"spec.signatureStores\""
  • [149.698 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 149.699 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "[Jira:\"Cluster Version Operator\"] cluster-version-operator cvo drops invalid conditional edges",
    "lifecycle": "informing",
    "duration": 149699,
    "startTime": "2026-03-27 07:14:01.255025 UTC",
    "endTime": "2026-03-27 07:16:30.954302 UTC",
    "result": "passed",
    "output": "  STEP: create upstream graph template with invalid conditional edges @ 03/27/26 15:14:05.139\n  STEP: run update service with the graph template @ 03/27/26 15:14:05.139\n  STEP: patch upstream with null target node conditional edge @ 03/27/26 15:14:09.946\n  STEP: prepare new graph file @ 03/27/26 15:14:12.386\n  STEP: create upstream graph template with multi risks conditional edges @ 03/27/26 15:14:12.387\n  STEP: run update service with the multi risks graph template @ 03/27/26 15:14:12.387\n  STEP: patch upstream with multi risks conditional edge @ 03/27/26 15:14:17.131\n"
  }
]
[jianl@jianl-thinkpadt14gen4 cluster-version-operator]$

With below new methods, we can create upstream cincinnati independently. CreateGraphTemplate() will help create a upstream graph template. RunUpdateService() will add upstream graph to a test pod. CreateService() will create a service. CreateNetworkPolicy() will create a network policy. CleanupService() will delete a service. DeleteDeployment() will delete a deployment. PatchUpstream() will patch upstream and channel. DeleteNetworkPolicy() will delete a network policy. Typically we follow below steps to create cincinnati: 1. CreateGraphTemplate - Create a graph text 2. RunUpdateService - Create a pod by deployment which host above graph 3. CreateService - Create graph url by creating UpdateService 4. CreateNetworkPolicy - Create a network policy which help us publish the graph url 5. PatchUpstream - Pathch above graph url and channel to cluster

JianLi-RH · 2026-03-27T07:22:33Z

/cc @hongkailiu @jiajliu

openshift-ci-robot · 2026-03-27T07:34:56Z

@JianLi-RH: This pull request explicitly references no jira issue.

Details

In response to this:

As we discussed in https://redhat-internal.slack.com/archives/CJ1J9C3V4/p1773852594419879?thread_ts=1773825774.280769&cid=CJ1J9C3V4

we can generate Cincinnati json and inject it to a test pod, then we use the pod's service URI for upstream.

This PR implements some common methods and finished test case: https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-46422

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-27T10:44:32Z

@JianLi-RH: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift	`8d7f449`	link	true	`/test e2e-hypershift`
ci/prow/e2e-hypershift-conformance	`8d7f449`	link	true	`/test e2e-hypershift-conformance`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2026

JianLi-RH force-pushed the common_method_for_adding_upstream branch 6 times, most recently from 469fa60 to 3963e80 Compare March 26, 2026 07:32

JianLi-RH force-pushed the common_method_for_adding_upstream branch 3 times, most recently from 0cad08f to 04fba21 Compare March 27, 2026 06:36

JianLi-RH force-pushed the common_method_for_adding_upstream branch from 04fba21 to 5fc7d7e Compare March 27, 2026 06:51

JianLi-RH force-pushed the common_method_for_adding_upstream branch from 5fc7d7e to 8d7f449 Compare March 27, 2026 07:18

JianLi-RH changed the title ~~[WIP] Adding common methods for inject upstream~~ Adding common methods for inject upstream Mar 27, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2026

openshift-ci bot requested review from hongkailiu and jiajliu March 27, 2026 07:22

JianLi-RH changed the title ~~Adding common methods for inject upstream~~ NO-ISSUE: automate OCP-46422 and adding in-cluster Cincinnati Mar 27, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NO-ISSUE: automate OCP-46422 and adding in-cluster Cincinnati#1354

NO-ISSUE: automate OCP-46422 and adding in-cluster Cincinnati#1354
JianLi-RH wants to merge 1 commit intoopenshift:mainfrom
JianLi-RH:common_method_for_adding_upstream

JianLi-RH commented Mar 19, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

Review skipped

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

JianLi-RH commented Mar 27, 2026 •

edited

Loading

Uh oh!

JianLi-RH commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

JianLi-RH commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

JianLi-RH commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JianLi-RH commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JianLi-RH commented Mar 19, 2026 •

edited

Loading

coderabbitai bot commented Mar 19, 2026 •

edited

Loading

JianLi-RH commented Mar 27, 2026 •

edited

Loading