STOR-3090: Enable pod-delete-after-umount CSI suite for driver OCP manifests

[radeore]

Summary

Enable the OpenShift CSI Pod delete after umount test suite for AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD by adding podDeleteAfterUmount: true to each driver's ocp-manifest.yaml.

This aligns csi-operator with the updated gating in openshift/origin#31488, which reads the capability from the OpenShift-specific CSI manifest (TEST_OCP_CSI_DRIVER_FILES) rather than the upstream external storage manifest (TEST_CSI_DRIVER_FILES).

Adds capability podDeleteAfterUmount: true to OpenShift CSI driver ocp-manifests:

test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml
test/e2e/gcp-pd/ocp-manifest.yaml

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@radeore: This pull request references STOR-3090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds PodDeleteAfterUmountTest: true to OpenShift CSI driver config manifests for:

test/e2e/aws-ebs/ocp-manifest.yaml
test/e2e/aws-efs/ocp-manifest.yaml
test/e2e/azure-disk/ocp-manifest.yaml
test/e2e/azure-file/ocp-manifest.yaml

This enables the 'OpenShift CSI extended - Pod delete after umount suite' for these drivers, aligning csi-operator test manifests with the new origin test-gating flag introduced in openshift/origin#31488.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: radeore
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a8ce48b3-f2e1-46e8-a29e-02e533fc8d29

📥 Commits

Reviewing files that changed from the base of the PR and between 504e9c1 and 5b224d8.

📒 Files selected for processing (5)

• test/e2e/aws-ebs/ocp-manifest.yaml
• test/e2e/aws-efs/ocp-manifest.yaml
• test/e2e/azure-disk/ocp-manifest.yaml
• test/e2e/azure-file/ocp-manifest.yaml
• test/e2e/gcp-pd/ocp-manifest.yaml

---

📝 Walkthrough

Walkthrough

The five CSI driver end-to-end test manifests now enable Capabilities.podDeleteAfterUmount: true for AWS EBS, AWS EFS, Azure Disk, Azure File, and GCP PD.

Suggested reviewers: dobsonj, stephenfin, jsafrane

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch only adds static YAML capability flags to five manifests; it adds no Ginkgo test titles or dynamic values.
Test Structure And Quality	✅ Passed	PASS: The diff changes only five YAML manifests; it adds no Ginkgo It blocks, setup/cleanup, cluster waits, or assertions to review.
Microshift Test Compatibility	✅ Passed	The diff changes only five YAML manifests by adding podDeleteAfterUmount; it adds no Ginkgo tests or MicroShift-relevant API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff contains only five YAML manifest additions; no new Ginkgo tests or topology-dependent test changes were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	The verified diff only adds Capabilities.podDeleteAfterUmount: true to five CSI test manifests; it adds no replicas, affinity, topology spread, node selection, toleration, or PDB constraints.
Ote Binary Stdout Contract	✅ Passed	The diff adds only YAML capability fields in five ocp-manifest files; it changes no process-level code or stdout/logging calls.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only five YAML manifests by adding podDeleteAfterUmount; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The diff only adds podDeleteAfterUmount: true to five YAML manifests; the added-line scan found no weak crypto, custom crypto, or secret-comparison usage.
Container-Privileges	✅ Passed	The diff adds only top-level podDeleteAfterUmount settings to five test manifests; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The commit adds only podDeleteAfterUmount: true to five YAML manifests; the diff introduces no logging statements or passwords, tokens, keys, PII, hostnames, or customer data.
Title check	✅ Passed	The title clearly summarizes the primary change: enabling the pod-delete-after-umount CSI suite through driver OCP manifests.
Description check	✅ Passed	The description directly explains the manifest updates, affected drivers, capability setting, and related gating change.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[radeore]

/retest-required

[radeore]

/retest-required

[openshift-ci]

@radeore: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.