[release-4.15] OCPBUGS-102805: CVE-2026-33814: replace golang.org/x/net with openshift-sustaining fork - #10837
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@mariocr73: This pull request references Jira Issue OCPBUGS-102805, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
99217e1 to
636ba60
Compare
…ift-sustaining fork Co-authored-by: Cursor <cursoragent@cursor.com>
636ba60 to
010d00a
Compare
|
@mariocr73: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
golang.org/x/net's real fix for CVE-2026-33814 (GO-2026-4918, malformed SETTINGS_MAX_FRAME_SIZE causing an infinite loop in golang.org/x/net/http2) ships in v0.53.0, which requires go>=1.25. This branch's go.mod declares go 1.20, so a direct module bump is not buildable here without also bumping the builder toolchain.
Uses
replace golang.org/x/net => github.com/openshift-sustaining/net v0.35.0-sec.3(the sustaining team's own downstream fork) which backports only the CVE-2026-33814 fix without requiring a toolchain bump. Same mechanism already used by other components in this CVE (e.g. openshift/csi-operator, openshift/azure-disk-csi-driver-operator, openshift/route-controller-manager). This branch already pinned golang.org/x/net via a directreplace; that replace was repointed to the fork tag instead of adding a second one (Go only allows one replace per module path).Verified:
go build ./...andgo vet ./...pass with this branch's real toolchain;govulncheckno longer reports GO-2026-4918 for this module.