Skip to content

Conversation

@ingvagabund
Copy link
Member

Pulling kubernetes#135372 in

… priority pods first so all low priority pods can be preempted
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2025
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-61515, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Pulling kubernetes#135372 in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2025
@openshift-ci openshift-ci bot requested review from deads2k and tkashem November 20, 2025 16:43
@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ingvagabund
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member Author

Checking https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_kubernetes/2524/pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial/1991545177520476160:

Kubernetes e2e suite: [It] [sig-scheduling] SchedulerPreemption [Serial] validates various priority Pods preempt expectedly with the async preemption [Feature:SchedulerAsyncPreemption] [FeatureGate:SchedulerAsyncPreemption] [Beta]

passed in 1m55s.

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund ingvagabund changed the title WIP: OCPBUGS-61515: UPSTREAM: <carry>: Re-enable temporarily disabled SchedulerPreemption test OCPBUGS-61515: UPSTREAM: <carry>: Re-enable temporarily disabled SchedulerPreemption test Dec 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@ingvagabund ingvagabund changed the title OCPBUGS-61515: UPSTREAM: <carry>: Re-enable temporarily disabled SchedulerPreemption test OCPBUGS-61515: UPSTREAM: 135390: Re-enable temporarily disabled SchedulerPreemption test Dec 1, 2025
… priority pods first so all low priority pods can be preempted
@ingvagabund ingvagabund force-pushed the upstream-scheduler-preemption-fix branch from 7936c45 to cfa45c7 Compare December 1, 2025 10:34
@openshift-ci-robot
Copy link

@ingvagabund: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ingvagabund ingvagabund changed the title OCPBUGS-61515: UPSTREAM: 135390: Re-enable temporarily disabled SchedulerPreemption test OCPBUGS-61515: UPSTREAM: 135372: Re-enable temporarily disabled SchedulerPreemption test Dec 1, 2025
@ingvagabund
Copy link
Member Author

Based on https://www.kubernetes.dev/resources/release/#kubernetes-v135 the release is scheduled for Dec 17. The upstream fix is not that critical for the release so likely the fix will not get merged soon.

@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2025

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp-serial cfa45c7 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-ovn-techpreview-serial-2of2 cfa45c7 link false /test e2e-aws-ovn-techpreview-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants