Skip to content

OSDOCS 17887: [ROSA] CQA for OSD Cluster Admin #112511

Open
jc-berger wants to merge 5 commits into
openshift:mainfrom
jc-berger:jcberger-osd-cluster-admin-CQA
Open

OSDOCS 17887: [ROSA] CQA for OSD Cluster Admin #112511
jc-berger wants to merge 5 commits into
openshift:mainfrom
jc-berger:jcberger-osd-cluster-admin-CQA

Conversation

@jc-berger

@jc-berger jc-berger commented May 29, 2026

Copy link
Copy Markdown
Contributor

Version(s):
4.21+

Issue:
https://redhat.atlassian.net/browse/OSDOCS-17887

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 29, 2026
@ocpdocs-previewbot

ocpdocs-previewbot commented May 29, 2026

Copy link
Copy Markdown

🤖 Wed Jun 10 15:13:43 - Prow CI generated the docs preview:
https://112511--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

Comment thread modules/aws-direct-connect.adoc Outdated
Comment thread modules/aws-direct-connect.adoc Outdated
Comment thread modules/aws-direct-connect.adoc Outdated
Comment thread modules/aws-direct-connect.adoc Outdated
Comment thread modules/aws-vpc.adoc Outdated
Comment thread modules/aws-vpc.adoc
Comment thread modules/aws-vpc.adoc Outdated
Comment thread modules/aws-direct-connect.adoc Outdated
Comment thread modules/aws-vpc.adoc Outdated
Comment thread modules/aws-vpn.adoc Outdated
Comment thread modules/aws-vpn.adoc Outdated
Comment thread modules/creating-a-machine-pool-ocm.adoc
Comment thread modules/creating-a-machine-pool-ocm.adoc
Comment thread modules/creating-a-machine-pool-ocm.adoc
Comment thread modules/creating-a-machine-pool-ocm.adoc Outdated
Comment thread modules/creating-a-machine-pool-ocm.adoc
Comment thread modules/enable-aws-access.adoc
Comment thread modules/enable-private-cluster-existing.adoc Outdated
Comment thread modules/enable-private-cluster-existing.adoc Outdated
Comment thread modules/enable-private-cluster-existing.adoc Outdated
Comment thread modules/enable-private-cluster-new.adoc Outdated
Comment thread modules/enable-private-cluster-new.adoc Outdated
Comment thread modules/enable-public-cluster.adoc Outdated
Comment thread modules/enable-public-cluster.adoc Outdated
Comment thread modules/managed-cluster-add-notification-contacts.adoc Outdated
Comment thread modules/osd-deploying-machinepool-single-az-gcp.adoc Outdated
Comment thread modules/osd-deploying-machinepool-single-az-gcp.adoc
Comment thread modules/osd-deploying-machinepool-single-az-gcp.adoc
Comment thread modules/rosa-scaling-worker-nodes.adoc
Comment thread modules/rosa-scaling-worker-nodes.adoc
Comment thread osd_cluster_admin/osd_private_connections/private-cluster.adoc
Comment thread osd_cluster_admin/osd_nodes/osd-managing-worker-nodes.adoc
Comment thread osd_cluster_admin/osd_nodes/osd-nodes-machinepools-about.adoc
@otikhomi

otikhomi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@jc-berger Thank you for this epic work! Lots of great changes, mostly clean previews and no AI oddities, thank you for taming Claude Code and reviewing its output thoroughly.

It might look like there're lots of comments but many of them are repeated (like Example output or expanding the same abbreviations), so there aren't many issues in the PR, Claude should be able to bulk-fix them fast.
Again, thanks for great work.

NB: I didn't leave comments for each:

  • docs.openshift.com link (there're 35 of them)
  • new verification section

When you address these 2 topics, please, check all of the instances yourself. Didn't want to flood the PR with identical comments.

@jc-berger jc-berger force-pushed the jcberger-osd-cluster-admin-CQA branch from 8d2f591 to 4d00c39 Compare June 9, 2026 13:40
Comment thread rosa_cluster_admin/rosa-nodes-about-autoscaling-nodes.adoc Outdated
Comment thread rosa_cluster_admin/rosa-nodes-about-autoscaling-nodes.adoc Outdated
@jc-berger jc-berger force-pushed the jcberger-osd-cluster-admin-CQA branch 6 times, most recently from 3ddc67b to 87d0718 Compare June 10, 2026 02:27
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2026
@jc-berger jc-berger force-pushed the jcberger-osd-cluster-admin-CQA branch from 87d0718 to 77be4d9 Compare June 10, 2026 02:31
@openshift-ci openshift-ci Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2026
Creating a machine pool with taints is only possible if the cluster already has at least one machine pool without a taint.
====
.. For each taint, select an *Effect* from the drop-down menu. Available options include `NoSchedule`, `PreferNoSchedule`, and `NoExecute`.
** *Node labels and taints*: Expand the *Edit node labels and taints* menu. Under *Node labels*, add *Key* and *Value* entries for your node labels. Under *Taints*, add *Key* and *Value* entries for your taints. For each taint, select an *Effect* from the drop-down menu. Available options include `NoSchedule`, `PreferNoSchedule`, and `NoExecute`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this content looks published, as previews aren't working, but it's not bold like this in VS code when I open the file.

@jc-berger jc-berger force-pushed the jcberger-osd-cluster-admin-CQA branch from 85a7ff7 to c4e99ff Compare June 10, 2026 14:15
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

@jc-berger: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants