TRT-2372: document the manifest-list verification in the images command #30818
TRT-2372: document the manifest-list verification in the images command #30818smg247 wants to merge 1 commit intoopenshift:mainfrom
Conversation
…ith a permanent exception to the rule
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@smg247: This pull request references TRT-2372 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughDocumentation updates to the image testing utilities README, adding a new section that specifies multi-architecture manifest list verification requirements, describes the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@smg247: This pull request references TRT-2372 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/extended/util/image/README.md (1)
40-46: Reduce drift risk by linking to the enforcement source of truth.Line 40 and Line 53 duplicate values that are likely enforced elsewhere (required architectures and permanent exceptions). Consider replacing hardcoded lists with links to the exact config/location in
openshift/release(or the check implementation), so this README does not go stale.Also applies to: 53-56
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/extended/util/image/README.md` around lines 40 - 46, The README currently hardcodes the list of required architectures and permanent exceptions for multi-arch manifest verification; instead, replace those duplicated values with links to the authoritative enforcement source (e.g., the specific config or check implementation in openshift/release or the `openshift-tests images --verify-manifest-lists` verification code) so the README references the canonical source of truth rather than repeating the lists; update the sections that list "required architectures" and "permanent exceptions" to link to the exact file/URL in openshift/release (or the check implementation) and add a short note that the README mirrors that source to avoid drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@test/extended/util/image/README.md`:
- Around line 40-46: The README currently hardcodes the list of required
architectures and permanent exceptions for multi-arch manifest verification;
instead, replace those duplicated values with links to the authoritative
enforcement source (e.g., the specific config or check implementation in
openshift/release or the `openshift-tests images --verify-manifest-lists`
verification code) so the README references the canonical source of truth rather
than repeating the lists; update the sections that list "required architectures"
and "permanent exceptions" to link to the exact file/URL in openshift/release
(or the check implementation) and add a short note that the README mirrors that
source to avoid drift.
ℹ️ Review info
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
test/extended/util/image/README.md
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neisw, smg247 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Along with a permanent exception to the rule
Summary by CodeRabbit
Documentation