Skip to content

OCPCLOUD-3010: Enable OTE for Cluster CAPI Operator#31307

Open
pmeida wants to merge 1 commit into
openshift:mainfrom
pmeida:ote-capi
Open

OCPCLOUD-3010: Enable OTE for Cluster CAPI Operator#31307
pmeida wants to merge 1 commit into
openshift:mainfrom
pmeida:ote-capi

Conversation

@pmeida

@pmeida pmeida commented Jun 16, 2026

Copy link
Copy Markdown

Summary

  • Adds cluster-capi-operator / /usr/bin/cluster-capi-operator-tests-ext.gz to the extensionBinaries registry in pkg/test/extensions/binary.go
  • Enables openshift-tests to extract and invoke the extension binary from the cluster-capi-operator payload image during test suite execution
  • The binary is added in the component with: OCPCLOUD-3009: Bootstrap OTE framework cluster-capi-operator#597 - must be merged first

Depends-On: openshift/cluster-capi-operator#597

Test plan

  • Verify openshift-tests discovers and extracts the binary from the cluster-capi-operator payload image at runtime
  • Confirm the extension binary appears in platform-wide periodic suites

Summary by CodeRabbit

Summary by CodeRabbit

  • Tests
    • Added an additional external test binary for the cluster-capi-operator image tag to improve cluster operator validation coverage.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot

openshift-ci-robot commented Jun 16, 2026

Copy link
Copy Markdown

@pmeida: This pull request references OCPCLOUD-3010 which is a valid jira issue.

Details

In response to this:

Summary

  • Adds cluster-capi-operator / /usr/bin/cluster-capi-operator-tests-ext.gz to the extensionBinaries registry in pkg/test/extensions/binary.go
  • Enables openshift-tests to extract and invoke the extension binary from the cluster-capi-operator payload image during test suite execution

Closes: https://issues.redhat.com/browse/OCPCLOUD-3010

Test plan

  • Verify openshift-tests discovers and extracts the binary from the cluster-capi-operator payload image at runtime
  • Confirm the extension binary appears in platform-wide periodic suites

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6b07859a-a964-444f-8f1b-f4eb8639f277

📥 Commits

Reviewing files that changed from the base of the PR and between efb461c and 623c117.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/test/extensions/binary.go

Walkthrough

A single TestBinary entry is added to the extensionBinaries registry in pkg/test/extensions/binary.go, mapping the cluster-capi-operator image tag to the binary path /usr/bin/cluster-capi-operator-tests-ext.gz. No other logic is modified.

Changes

Extension binary registration

Layer / File(s) Summary
Add cluster-capi-operator to extensionBinaries registry
pkg/test/extensions/binary.go
Registers a new TestBinary entry for the cluster-capi-operator image tag, pointing to /usr/bin/cluster-capi-operator-tests-ext.gz.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically references the JIRA ticket (OCPCLOUD-3010) and describes the main change: enabling OTE (Open Test Extension) for the Cluster CAPI Operator component by registering its extension binary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds only a static configuration entry to extensionBinaries registry with no Ginkgo test definitions or dynamic test names being introduced.
Test Structure And Quality ✅ Passed PR does not add or modify any Ginkgo test code; it only adds a registry entry to extensionBinaries. The custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed This PR only adds a registry entry for the cluster-capi-operator extension binary in pkg/test/extensions/binary.go. No new Ginkgo e2e tests (It(), Describe(), Context(), When()) are added, so the M...
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests (It, Describe, Context, When). It only registers an external test binary reference in pkg/test/extensions/binary.go, which is infrastructure configurat...
Topology-Aware Scheduling Compatibility ✅ Passed Change is a test binary registry entry with no Kubernetes scheduling constraints, manifests, or deployment code that could affect topology compatibility.
Ote Binary Stdout Contract ✅ Passed PR only adds a static registry entry (4 lines) for cluster-capi-operator with image tag and binary path strings. No process-level code, stdout writes, or executable code is added. The actual binary...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests. It only modifies pkg/test/extensions/binary.go to register the cluster-capi-operator extension binary in the extensionBinaries registry. The file contains...
No-Weak-Crypto ✅ Passed The PR adds a simple registry entry for cluster-capi-operator with no crypto operations, imports, or algorithms used. The change contains only string field assignments in a struct.
Container-Privileges ✅ Passed PR modifies only Go source code (pkg/test/extensions/binary.go) to register a test binary, not Kubernetes or container manifests. Container-privileges check does not apply.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds a simple struct literal entry to the extensionBinaries array containing only public constants: imageTag "cluster-capi-operator" and binaryPath "/usr/bin/cluster-capi-operator-tests-ext....

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pmeida pmeida changed the title OCPCLOUD-3010: Add cluster-capi-operator OTE binary to extensionBinaries list OCPCLOUD-3010: Enable OTE for Cluster CAPI Operator Jun 16, 2026
@openshift-ci openshift-ci Bot requested review from deads2k and p0lyn0mial June 16, 2026 08:12
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmeida
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2026
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Hi @pmeida. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 16, 2026
@pmeida

pmeida commented Jun 16, 2026

Copy link
Copy Markdown
Author

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@pmeida

pmeida commented Jun 17, 2026

Copy link
Copy Markdown
Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial openshift/cluster-capi-operator#597

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ec85100-6a20-11f1-9161-4db964fb4ac7-0

@pmeida

pmeida commented Jun 17, 2026

Copy link
Copy Markdown
Author

/testwith openshift/cluster-capi-operator#597

@pmeida

pmeida commented Jun 17, 2026

Copy link
Copy Markdown
Author

/retest-required

@pmeida

pmeida commented Jun 17, 2026

Copy link
Copy Markdown
Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial openshift/cluster-capi-operator#597

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@pmeida: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@pmeida

pmeida commented Jun 17, 2026

Copy link
Copy Markdown
Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial openshift/cluster-capi-operator#597

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/82c90270-6a52-11f1-957c-4b4344f0a90d-0

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@pmeida: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@pmeida

pmeida commented Jun 17, 2026

Copy link
Copy Markdown
Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial openshift/cluster-capi-operator#597

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6368a090-6a82-11f1-9ad7-d4d55b94e3ee-0

@pmeida

pmeida commented Jun 22, 2026

Copy link
Copy Markdown
Author

/retest

1 similar comment
@pmeida

pmeida commented Jun 22, 2026

Copy link
Copy Markdown
Author

/retest

Register the cluster-capi-operator extension binary in the payload
extension registry so openshift-tests can extract and invoke it
during test suite execution.

Closes: https://issues.redhat.com/browse/OCPCLOUD-3010

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@pmeida

pmeida commented Jun 22, 2026

Copy link
Copy Markdown
Author

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@pmeida

pmeida commented Jun 22, 2026

Copy link
Copy Markdown
Author

/verified by @pmeida

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@pmeida: This PR has been marked as verified by @pmeida.

Details

In response to this:

/verified by @pmeida

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmeida

pmeida commented Jun 22, 2026

Copy link
Copy Markdown
Author

/retest

1 similar comment
@pmeida

pmeida commented Jun 22, 2026

Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants