OCPBUGS-86789: Make early request monitor test informing

[jacobsee]

Early requests have been occurring and have been uncaught due to an event emission error in KAS. Making it informing here (for now) allows us to keep collecting data on it but not block the event emission fix on an actual early request fix (both of which need to happen).

Summary by CodeRabbit

• Tests
  • Updated test infrastructure to improve robustness of API server graceful termination validation.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

A new import alias ote is added for the OpenShift tests extension Ginkgo helpers, and the API LBs "don't send request early" test registration is updated to pass ote.Informing() as an argument to g.It(...).

Graceful termination test update

Layer / File(s)	Summary
Import ote and apply Informing label test/extended/apiserver/graceful_termination.go	Adds ote import alias and adds ote.Informing() to the g.It(...) call for the API LBs early-request test. No other logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	⚠️ Warning	New test file references unavailable openshift-kube-apiserver namespace without MicroShift compatibility protections (no [Skipped:MicroShift], [apigroup:...], or IsMicroShiftCluster() checks).	Add [Skipped:MicroShift] label to test names or guard tests with IsMicroShiftCluster() check, or add [apigroup:...] tag for unavailable API group.
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	New test file adds 5 Ginkgo tests that iterate over master nodes without SNO compatibility checks. The "kubelet terminates kube-apiserver gracefully extended" test queries for nodes with "node-role...	Add [Skipped:SingleReplicaTopology] label to tests that assume multiple or specifically-labeled nodes, or guard tests with exutil.IsSingleNode() check per SNO compatibility options provided in the custom check instructions.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names in the modified file are stable, deterministic string literals with no dynamic content; no pod names, timestamps, UUIDs, node names, or other changing values appear in test titles.
Test Structure And Quality	✅ Passed	Modified test meets all 5 quality requirements: single responsibility (checks NonReadyRequests only), proper setup/cleanup (read-only, no resources created), assertion messages (descriptive t.Error...
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only a test file (test/extended/apiserver/graceful_termination.go), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	No OTE Binary Stdout Contract violations found. The PR only adds ote.Informing() decorator to a test, which is a metadata object that doesn't write to stdout. No process-level stdout writes detected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Custom check is for NEW Ginkgo tests; this PR only modifies an existing test by adding ote.Informing() parameter, not adding new tests.
No-Weak-Crypto	✅ Passed	File contains no cryptographic code, weak crypto usage, custom crypto implementations, or insecure secret comparisons. Only test framework modifications present.
Container-Privileges	✅ Passed	PR modifies only test code (graceful_termination.go), not container/K8s manifests. Container privilege check is not applicable to test code changes.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds ote.Informing() metadata label to a test; it doesn't introduce new logging or expose sensitive data like passwords, tokens, API keys, or PII.
Title check	✅ Passed	The title clearly matches the change to make the early request monitor test informing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[jacobsee]

/retest

[benluddy]

The type assertion in https://github.com/openshift/kubernetes/pull/356/changes#diff-0f5f60e15dd9d3f03072c40e330d918d6afcb81144af5162f87741102e425566R123 has failed silently from the beginning because the type of the anonymous bound method stored in unexpectedRequestsEventf is distinct from the named type "eventfFunc", even though both types are functions with identical signatures. As a result, the event this monitor expects could never be emitted. This means the we have no valid history for the test in question as a baseline for comparison.

There's a release blocking issue to fix the early/unready requests that are now surfacing (https://redhat.atlassian.net/browse/OCPBUGS-86789), but I think it's reasonable to unblock the rebase by temporarily making the test non-blocking. It is effectively a new test.

/cc @p0lyn0mial @bertinatto

[jubittajohn]

/retest

[bertinatto]

The type assertion in https://github.com/openshift/kubernetes/pull/356/changes#diff-0f5f60e15dd9d3f03072c40e330d918d6afcb81144af5162f87741102e425566R123 has failed silently from the beginning because the type of the anonymous bound method stored in unexpectedRequestsEventf is distinct from the named type "eventfFunc", even though both types are functions with identical signatures. As a result, the event this monitor expects could never be emitted. This means the we have no valid history for the test in question as a baseline for comparison.

There's a release blocking issue to fix the early/unready requests that are now surfacing (https://redhat.atlassian.net/browse/OCPBUGS-86789), but I think it's reasonable to unblock the rebase by temporarily making the test non-blocking. It is effectively a new test.

/cc @p0lyn0mial @bertinatto

I agree with this, sounds like we have a plan.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jacobsee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacobsee]

/retitle OCPBUGS-86789: Make early request monitor test informing

[openshift-ci-robot]

@jacobsee: This pull request references Jira Issue OCPBUGS-86789, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Early requests have been occurring and have been uncaught due to an event emission error in KAS. Making it informing here (for now) allows us to keep collecting data on it but not block the event emission fix on an actual early request fix (both of which need to happen).

Summary by CodeRabbit

• Tests
• Updated test infrastructure to improve robustness of API server graceful termination validation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jacobsee]

/verified by ci

[openshift-ci-robot]

@jacobsee: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jacobsee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jacobsee: Jira Issue Verification Checks: Jira Issue OCPBUGS-86789
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-86789 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Early requests have been occurring and have been uncaught due to an event emission error in KAS. Making it informing here (for now) allows us to keep collecting data on it but not block the event emission fix on an actual early request fix (both of which need to happen).

Summary by CodeRabbit

• Tests
• Updated test infrastructure to improve robustness of API server graceful termination validation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.